Bug 10031 - runreport.pl has an error
Summary: runreport.pl has an error
Status: RESOLVED DUPLICATE of bug 9033
Alias: None
Product: Koha
Classification: Unclassified
Component: Task Scheduler (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 07:18 UTC by Ketan Kulkarni
Modified: 2013-04-29 21:30 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ketan Kulkarni 2013-04-12 07:18:51 UTC
The code that's hashed out is the current code. The lines below that are the lines that should be present instead. A minor typographical error.

Following is the output of diff command showing the difference between the original file and the update file - bin/cronjobs/runreport.pl

=================================================================

195,197c195,201
<     my $sql         => $report->{savedsql};
<     my $report_name => $report->{report_name};
<     my $type        => $report->{type};
---
>     #my $sql         => $report->{savedsql};
>     my $sql         = $report->{savedsql};
> #print $sql;
>     #my $report_name => $report->{report_name};
>     my $report_name = $report->{report_name};
>     #my $type        => $report->{type};
>     my $type        = $report->{type};

=================================================================

New to koha. Looking for info on submitting a patch myself.
Comment 1 Chris Cormack 2013-04-29 21:30:30 UTC
Hi Ketan

These pages might help you

http://wiki.koha-community.org/wiki/SubmitingAPatch
http://wiki.koha-community.org/wiki/Guidelines_for_Patch_Acceptance/Rejection
http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow

And a more general git one

http://wiki.koha-community.org/wiki/Version_Control_Using_Git

Or jump on irc.oftc.net #koha and chat with the developers there.

For a patch to fix this,
A git patch attached to the bug with a nice commit message would be sufficient. However I notice this problem is not present in the master branch.

What version of Koha did you spot it in?
It was fixed in Bug 9033 and released in 3.10.1

You can see the patch here
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14012&action=diff

*** This bug has been marked as a duplicate of bug 9033 ***