Bug 10702 - can't create notices for a specific branch
Summary: can't create notices for a specific branch
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-08 19:38 UTC by Nicole C. Engard
Modified: 2016-06-21 21:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-08-08 19:38:42 UTC
When creating a new notice if I choose my branch and then the module the branch changes back to 'all libraries'. I then change the branch back to mine and enter the code and text and have everything in place and hit save.  When I save it doesn't save. The notice is lost.  Right now you have to create the notice for 'all libraries' and then copy the notice to my library and then delete the 'all libraries copy'.
Comment 1 Nicole C. Engard 2013-08-13 14:04:23 UTC
Is this the same as what's fixed in bug 10439 ?
Comment 2 Jonathan Druart 2014-03-06 13:02:52 UTC
I cannot reproduce on master.
Comment 3 Katrin Fischer 2014-07-12 14:44:01 UTC
Part of the problem here is that the page reloads when you change the module after selecting the branch. A first fix to avoid more confusion would be switching the order of the fields and put the module first. A better solution would be to avoid the reloading.
Comment 4 Jonathan Druart 2014-07-15 08:35:53 UTC
Actually, the reloading permits to refresh the fields list. I think we should keep this behavior.
Comment 5 Katrin Fischer 2014-07-15 08:39:01 UTC
I thnk avoiding the page reload will require more work - like using Ajax to reload only the field list. Switching the field order could help a bit to make it less irritating.
Comment 6 Owen Leonard 2014-10-24 16:45:09 UTC
(In reply to Nicole C. Engard from comment #0)
> When creating a new notice if I choose my branch and then the module the
> branch changes back to 'all libraries'.

Confirmed. If changing the module reloads the page without warning we might do fix it a number of ways:

- Use Ajax to reload only the field list as Jonathan suggests
- Convert the "New notice" button to a menu which lists the possible
  module choices
- Add an intermediate step where you must submit a module choice
  before rest of the form displays.

> When I save it doesn't save. The notice is lost.

I cannot reproduce this problem. Please test again in master. If the problem can't be reproduced I suggest we close this bug and create a new one for the module-switching problem.
Comment 7 Katrin Fischer 2015-06-07 10:02:48 UTC
I can't reproduce the problem with the form not saving either. I files a new bug 14358 for the refreshing of the page when changing the module.ill file