The staff interface allows creating suggestions for "Any library". In this case the branchcode used in the suggestions table is _ANY_. I think this creates a few problem. I think one will be that we can't create a FK constraint on the branchcode for the suggestions table. It would also be more consistent with other code in Koha to use an empty branchcode for any library.
Should we add a branch at install, that is the equivalent of any in the code, that cannot be deleted? Basically a shadow branch, just for this purpose?
Created attachment 34307 [details] [review] Bug 10753: Any library is represented by an empty string And not with "__ANY__" Test plan: 0/ Don't apply this patch 1/ Create a suggestion for "any library" 2/ Verify suggestions.branchcode contain "__ANY__" 3/ Apply this patch and execute the updatedb entry 4/ Create a suggestion for "any library" 5/ Verify suggestions.branchcode contain "" (for both suggestions).
I am under the impression that this simple patch fixes the problem. Someone to confirm?
I've applied the patch against master 3.19.00.000 There are some [and case?] errors in the patch: Web installer › Step 3 Updating database structure Update errors : [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/..../installer/data/mysql/updatedatabase.pl line 9588. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/..../installer/data/mysql/updatedatabase.pl line 9589. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/.../installer/data/mysql/updatedatabase.pl line 9593. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/..../installer/data/mysql/updatedatabase.pl line 9594. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Execution of /var/root-koha/..../installer/data/mysql/updatedatabase.pl aborted due to compilation errors. I pass the patch to "Failed QA" status.
Created attachment 34412 [details] [review] Bug 10753: Any library is represented by an empty string And not with "__ANY__" Test plan: 0/ Don't apply this patch 1/ Create a suggestion for "any library" 2/ Verify suggestions.branchcode contain "__ANY__" 3/ Apply this patch and execute the updatedb entry 4/ Create a suggestion for "any library" 5/ Verify suggestions.branchcode contain "" (for both suggestions).
(In reply to Paola Rossi from comment #4) > I've applied the patch against master 3.19.00.000 > > There are some [and case?] errors in the patch: > > Web installer › Step 3 > Updating database structure > > Update errors : Sorry about that.
Created attachment 34413 [details] [review] Bug 10753: Any library is represented by an empty string Thanks, Jonathan. I've applied the patch against 3.19.00.000 Everything is OK as required. So I pass the patch to "Signed Off" status.
Created attachment 34538 [details] [review] [PASSED QA] Bug 10753: Any library is represented by an empty string And not with "__ANY__" Test plan: 0/ Don't apply this patch 1/ Create a suggestion for "any library" 2/ Verify suggestions.branchcode contain "__ANY__" 3/ Apply this patch and execute the updatedb entry 4/ Create a suggestion for "any library" 5/ Verify suggestions.branchcode contain "" (for both suggestions). Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
Template changes, held for 3.18.3
Pushed to 3.18.x will be in 3.18.3
Contains DB changes, passing for 3.16.x