Bug 10928 - Acq Note does not appear when receiving an order
Summary: Acq Note does not appear when receiving an order
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Mathieu Saby
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-21 08:51 UTC by Mathieu Saby
Modified: 2015-12-03 22:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 10928 - Make orders note visible when receiving an order (2.18 KB, patch)
2013-11-11 21:27 UTC, Mathieu Saby
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-09-21 08:51:56 UTC
The textarea for note is blank when receving a parcel.
Probably because "notes" column exist in biblio and in aqorders and the sub SearchOrder is just doing "SELECT *"

M. Saby
Comment 1 Mathieu Saby 2013-11-11 21:27:43 UTC
Created attachment 22861 [details] [review]
Bug 10928 - Make orders note visible when receiving an order

notes field is used in biblio table as well as in aqorders table, so results are messed up.
The SQL query in C4:Acquisitions:SearchOrders must be changed.
This is also the case for timestamp field.

This patch change C4:Acquisitions:SearchOrders:
- biblio.* is replaced with all fields of biblio table
- except for notes, returned as biblionotes and tilmestamp as bibliotimestamp

Further improvements could be made later (as suppressing useless biblio.fields from the query).

To test :
create an order with an order note
receive this order, and check the order note is visible in the textarea dedicated to that purpose
Comment 2 Mathieu Saby 2013-11-11 21:28:34 UTC
Nicole, I see you add yourself to this bug. I made a little patch for it.

Mathieu
Comment 3 Christopher Brannon 2013-12-31 22:28:15 UTC
Mathieu,
It could just be that I am not familiar enough with Acquisitions, but I don't see the problem.  When receiving an order, I can see the order note without the patch.  Can you be more specific as to what version of Koha you are using, and what screen it is missing from?

Thanks.

Christopher
Comment 4 Mathieu Saby 2014-01-01 11:01:30 UTC
(In reply to Christopher Brannon from comment #3)
> Mathieu,
> It could just be that I am not familiar enough with Acquisitions, but I
> don't see the problem.  When receiving an order, I can see the order note
> without the patch.  Can you be more specific as to what version of Koha you
> are using, and what screen it is missing from?
> 
> Thanks.
> 
> Christopher

Hello
Maybe it has been fix by an other bug.
I can check it now, so I set it in discussion for the moment.

Mathieu
Comment 5 Jonathan Druart 2015-02-23 16:02:32 UTC
We have aqorders.order_vendornote which is displayed on receiving.