Bug 5770 - Email librarian when purchase suggestion made
Summary: Email librarian when purchase suggestion made
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Devinim
QA Contact: Bugs List
URL: http://devs.bywatersolutions.com/proj...
Whiteboard:
Keywords:
: 7322 19459 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-16 21:02 UTC by Nicole C. Engard
Modified: 2019-02-20 20:54 UTC (History)
9 users (show)

See Also:
Change sponsored?: Seeking cosponsors
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 5770: New system pref for new suggestion email (3.68 KB, patch)
2018-12-19 11:35 UTC, Devinim
Details | Diff | Splinter Review
Bug 5770: Notify for new suggestion (3.60 KB, patch)
2018-12-19 12:01 UTC, Devinim
Details | Diff | Splinter Review
Bug 5770: Notify for new suggestion - sample notices (25.27 KB, patch)
2018-12-19 12:19 UTC, Devinim
Details | Diff | Splinter Review
Bug 5770: (follow-up) New system pref for new suggestion email (1.59 KB, patch)
2018-12-19 12:38 UTC, Devinim
Details | Diff | Splinter Review
Bug 5770: Email librarian when purchase suggestion made (1.99 KB, patch)
2018-12-19 13:38 UTC, Devinim
Details | Diff | Splinter Review
Bug 5770: New system pref and notice for new suggestion email (4.87 KB, patch)
2018-12-19 13:47 UTC, Devinim
Details | Diff | Splinter Review
Bug 5770: Notify for new suggestion - sample notices (25.30 KB, patch)
2019-01-03 13:46 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 5770: Email librarian when purchase suggestion made (2.04 KB, patch)
2019-01-03 13:46 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 5770: New system pref for new suggestion email (4.92 KB, patch)
2019-01-03 13:46 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 5770: (QA follow-up) Minor formatting fixes (106.92 KB, patch)
2019-01-27 12:56 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 5770: Unit test and skeleton perl (11.51 KB, patch)
2019-02-06 12:03 UTC, Devinim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-02-16 21:02:09 UTC
Right now there are a series of notices that get sent to patrons when actions happen to their suggestions, but I think we also need a preference or a setting to have new purchase suggestions go via email to the librarian.

This would be handy for the libraries that don't use acquisitions for anything but purchase suggestions.
Comment 1 mathieu saby 2013-10-13 09:11:24 UTC
Very very needed!
As the patron does not know which librarian will manage its suggestion, new suggestions notices could be sent either to the Acq manager for the library system, or to the Acq manager for each branch of the system, if a branch is specified by the patron.

M. Saby
Comment 2 Katrin Fischer 2014-02-21 12:17:59 UTC
*** Bug 7322 has been marked as a duplicate of this bug. ***
Comment 3 Nicole C. Engard 2016-01-06 16:30:21 UTC
Seeking co-sponsors: http://devs.bywatersolutions.com/projects/new-suggestions-sent-via-email/
Comment 4 Katrin Fischer 2018-06-10 11:20:43 UTC
*** Bug 19459 has been marked as a duplicate of this bug. ***
Comment 5 Devinim 2018-12-19 11:35:46 UTC Comment hidden (obsolete)
Comment 6 Devinim 2018-12-19 12:01:41 UTC Comment hidden (obsolete)
Comment 7 Devinim 2018-12-19 12:19:34 UTC
Created attachment 83386 [details] [review]
Bug 5770: Notify for new suggestion - sample notices

This patch adds the new notice for all languages.
Comment 8 Devinim 2018-12-19 12:38:34 UTC Comment hidden (obsolete)
Comment 9 Devinim 2018-12-19 13:38:17 UTC
Created attachment 83388 [details] [review]
Bug 5770: Email librarian when purchase suggestion made

Test plan:
1 - Make sure create a new notice suggestions >  NEW_SUGGESTION
2 - Change EmailPurchaseSuggestions and  EmailAddressForSuggestions system preferences.
3 - Create a suggestion
4 - Verify the notice is generated in the message_queue table.
6 - Verify that the e-mail will be sent to the address specified in the EmailPurchaseSuggestions system preferences.
7 - And then return to 2.
8 - Repeat steps.
Comment 10 Devinim 2018-12-19 13:47:48 UTC
Created attachment 83390 [details] [review]
Bug 5770: New system pref and notice for new suggestion email
Comment 11 Katrin Fischer 2018-12-20 21:32:58 UTC
Hi, please don't forget to assign the bug to yourself when providing a patch!
Comment 12 Nick Clemens 2019-01-03 13:46:43 UTC
Created attachment 83615 [details] [review]
Bug 5770: Notify for new suggestion - sample notices

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 13 Nick Clemens 2019-01-03 13:46:47 UTC
Created attachment 83616 [details] [review]
Bug 5770: Email librarian when purchase suggestion made

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 14 Nick Clemens 2019-01-03 13:46:50 UTC
Created attachment 83617 [details] [review]
Bug 5770: New system pref for new suggestion email

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 15 Nick Clemens 2019-01-03 13:49:34 UTC
Works as advertised, a few notes:
1 - I encourage everyone to use skeleton.perl as a base for update statements :-) - perl ones are easier to push
2 - I would like to see the new notice use TT syntax instead of our legacy syntax
Comment 16 Katrin Fischer 2019-01-27 12:56:01 UTC
Created attachment 84463 [details] [review]
Bug 5770: (QA follow-up) Minor formatting fixes

- Rewords system preference slightly
- Minor changes to the sample template like
  " : " to ": "
- Alphabetizes sysprefs.sql
Comment 17 Katrin Fischer 2019-01-27 13:00:40 UTC
I'd like TT syntax, but I think we could deal with it separately as not all notices are TT yet. If we do TT we might want to do not just a conversion, but also do a nice one, using [% IF (....) %] to avoid empty labels and the like.

I've added a follow-up doing some minor changes - plz have a look at those.

Failing for missing tests for the change on NewSuggestion. Please add tests!
Comment 18 Devinim 2019-02-06 12:03:58 UTC
Created attachment 84812 [details] [review]
Bug 5770: Unit test and skeleton perl
Comment 19 Katrin Fischer 2019-02-06 12:09:15 UTC
Hi Devinim, most of the time if something is failed by the QA team it's ok to switch directly back "Signed off". Tests are such a case :)