Right now there are a series of notices that get sent to patrons when actions happen to their suggestions, but I think we also need a preference or a setting to have new purchase suggestions go via email to the librarian. This would be handy for the libraries that don't use acquisitions for anything but purchase suggestions.
Very very needed! As the patron does not know which librarian will manage its suggestion, new suggestions notices could be sent either to the Acq manager for the library system, or to the Acq manager for each branch of the system, if a branch is specified by the patron. M. Saby
*** Bug 7322 has been marked as a duplicate of this bug. ***
Seeking co-sponsors: http://devs.bywatersolutions.com/projects/new-suggestions-sent-via-email/
*** Bug 19459 has been marked as a duplicate of this bug. ***
Created attachment 83384 [details] [review] Bug 5770: New system pref for new suggestion email Add two new system preferences for new suggestion email.
Created attachment 83385 [details] [review] Bug 5770: Notify for new suggestion Test plan: 1 - Make sure create a new notice suggestions > NEW_SUGGESTION 2 - Change EmailPurchaseSuggestions and EmailAddressForSuggestions system preferences. 3 - Create a suggestion 4 - Verify the notice is generated in the message_queue table. 6 - Verify that the e-mail will be sent to the address specified in the EmailPurchaseSuggestions system preferences. 7 - And then return to 2. 8 - Repeat steps.
Created attachment 83386 [details] [review] Bug 5770: Notify for new suggestion - sample notices This patch adds the new notice for all languages.
Created attachment 83387 [details] [review] Bug 5770: (follow-up) New system pref for new suggestion email
Created attachment 83388 [details] [review] Bug 5770: Email librarian when purchase suggestion made Test plan: 1 - Make sure create a new notice suggestions > NEW_SUGGESTION 2 - Change EmailPurchaseSuggestions and EmailAddressForSuggestions system preferences. 3 - Create a suggestion 4 - Verify the notice is generated in the message_queue table. 6 - Verify that the e-mail will be sent to the address specified in the EmailPurchaseSuggestions system preferences. 7 - And then return to 2. 8 - Repeat steps.
Created attachment 83390 [details] [review] Bug 5770: New system pref and notice for new suggestion email
Hi, please don't forget to assign the bug to yourself when providing a patch!
Created attachment 83615 [details] [review] Bug 5770: Notify for new suggestion - sample notices Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 83616 [details] [review] Bug 5770: Email librarian when purchase suggestion made Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 83617 [details] [review] Bug 5770: New system pref for new suggestion email Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Works as advertised, a few notes: 1 - I encourage everyone to use skeleton.perl as a base for update statements :-) - perl ones are easier to push 2 - I would like to see the new notice use TT syntax instead of our legacy syntax
Created attachment 84463 [details] [review] Bug 5770: (QA follow-up) Minor formatting fixes - Rewords system preference slightly - Minor changes to the sample template like " : " to ": " - Alphabetizes sysprefs.sql
I'd like TT syntax, but I think we could deal with it separately as not all notices are TT yet. If we do TT we might want to do not just a conversion, but also do a nice one, using [% IF (....) %] to avoid empty labels and the like. I've added a follow-up doing some minor changes - plz have a look at those. Failing for missing tests for the change on NewSuggestion. Please add tests!
Created attachment 84812 [details] [review] Bug 5770: Unit test and skeleton perl
Hi Devinim, most of the time if something is failed by the QA team it's ok to switch directly back "Signed off". Tests are such a case :)