These tests are not run regularly and they are now completely broken.
Created attachment 64289 [details] [review] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass
Created attachment 64290 [details] [review] Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" />
Created attachment 64291 [details] [review] Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();">
Created attachment 64292 [details] [review] Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled
Additional information: To test this patch: % wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.1.jar % sudo apt-get install xvfb firefox-esr % SELENIUM_PATH=/home/vagrant/selenium-server-standalone-2.53.1.jar % Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & % DISPLAY=:1 java -jar $SELENIUM_PATH Remove the rentalcharge: % UPDATE itemtypes SET rentalcharge = 0; Then you can execute the test file. If you get: Wide character in print at /usr/local/share/perl/5.20.2/Test2/Formatter/TAP.pm line 105. # 'Koha › Patrons › Add patron test_patron_surname (Adult)' # doesn't match '(?^u:Patron details for test_patron_surname)' Ignore and retry (FIXME LATER...) No need to say that this code needs more love. The plan here is to make the tests pass, it will already be a big step. Tested on 17.05.x, 16.11.x and 16.05.x
Block RM actions (cannot test before pushing stuffs).
Created attachment 64358 [details] [review] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 64359 [details] [review] Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" /> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 64360 [details] [review] Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 64361 [details] [review] Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 64362 [details] [review] [SIGNED-OFF] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 64363 [details] [review] [SIGNED-OFF] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 64365 [details] [review] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 64366 [details] [review] Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" /> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 64367 [details] [review] Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 64368 [details] [review] Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Created attachment 64373 [details] [review] Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed We do not want these tests to fail if the module is not installed. This module is not in the dependencies of Koha and it is good as it. A developper who wants to use it will know what to do. It is part of RM duties to make sure these tests pass Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 64374 [details] [review] Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector Bug 16286 replaced the submit node: <input type="button" value="Save" onclick="Check(this.form);" /> with <input type="submit" value="Save" /> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 64375 [details] [review] Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector With bug 11088 and bug 16400 the submit node switched from: <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" /> to: <button type="submit" name="save" onclick="return check_form_borrowers"> then finally to: <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();"> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 64376 [details] [review] Bug 18804: (bug 13501 follow-up) Fix add item form (select2) Hard to say here, select2 adds so many elements that we need to ignore. Here we just assume that input text with an id starting with tag_952_subfield must be filled Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 64417 [details] [review] Bug 18804: Add additional information to execute successfuly selenium tests
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.02
Tested successfully in 16.11.x. (thx for comment#5, Jonathan!) These patches have been pushed to 16.11.x and will be in 16.11.10.
Pushed to 16.05.x, for 16.05.15 release