addbiblio.pl has a hard-coded (and therefore untranslatable) "Tag editor" text. It appears in two places in the code. Also: print "Content-Type: text/html\n\n<html><body><h1>ERROR when DELETING BIBLIO $biblionumber : $error</h1></body></html>";
I find these instances of the phrase "tag editor" in .pl and .pm files: Line 220 of authorities\authorities.pl Line 252 of authorities\authorities.pl Line 2833 of C4\Items.pm Line 398 of cataloguing\addbiblio.pl Line 427 of cataloguing\addbiblio.pl Line 238 of cataloguing\additem.pl Line 255 of cataloguing\additem.pl Line 404 of tools\batchMod.pl Line 418 of tools\batchMod.pl
Created attachment 27922 [details] [review] Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug.
Changed Bug description and component
Created attachment 27928 [details] [review] Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan
*** Bug 682 has been marked as a duplicate of this bug. ***
(In reply to Owen Leonard from comment #1) > I find these instances of the phrase "tag editor" in .pl and .pm files: > > Line 238 of cataloguing\additem.pl > Line 255 of cataloguing\additem.pl This two in Bug 12176
(In reply to Owen Leonard from comment #1) > I find these instances of the phrase "tag editor" in .pl and .pm files: > > Line 220 of authorities\authorities.pl > Line 252 of authorities\authorities.pl This two in Bug 12177
(In reply to Owen Leonard from comment #1) > I find these instances of the phrase "tag editor" in .pl and .pm files: > > Line 404 of tools\batchMod.pl > Line 418 of tools\batchMod.pl This two in Bug 12180
Created attachment 29462 [details] [review] Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 29492 [details] [review] [PASSED QA] Bug 11638 - Remove HTML from addbiblio.pl This patch extracts variables with HTML from addbiblio.pl and an instance of CGI::scrolling_list As it changes how MARC editor show input fields, I prefer not add patches for other cases mentioned on Comment #1 To test: 1. Verify there are no regressions on MARC editor Add/Edit records, modify values 2. Update translation file for a language, check new string 'Tag editor' About the error message on error when deleting biblio, it must be localized but the script is not trying to use a template file, only prints a basic html and aborts. Perhaps a way of handling errors more gracefully is needed, but again it need to be solved on it's own bug. Updated test plan Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Bernardo!