Bug 11638 - Remove HTML from addbiblio.pl
Summary: Remove HTML from addbiblio.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
: 682 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-30 07:20 UTC by paxed
Modified: 2015-06-04 23:32 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11638 - Remove HTML from addbiblio.pl (12.93 KB, patch)
2014-05-02 22:05 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11638 - Remove HTML from addbiblio.pl (12.97 KB, patch)
2014-05-03 22:25 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11638 - Remove HTML from addbiblio.pl (13.02 KB, patch)
2014-07-03 05:10 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11638 - Remove HTML from addbiblio.pl (13.09 KB, patch)
2014-07-03 15:25 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-30 07:20:40 UTC
addbiblio.pl has a hard-coded (and therefore untranslatable) "Tag editor" text. It appears in two places in the code.

Also:
print "Content-Type: text/html\n\n<html><body><h1>ERROR when DELETING BIBLIO $biblionumber : $error</h1></body></html>";
Comment 1 Owen Leonard 2014-01-30 13:38:11 UTC
I find these instances of the phrase "tag editor" in .pl and .pm files:

Line 220 of authorities\authorities.pl
Line 252 of authorities\authorities.pl
Line 2833 of C4\Items.pm
Line 398 of cataloguing\addbiblio.pl
Line 427 of cataloguing\addbiblio.pl
Line 238 of cataloguing\additem.pl
Line 255 of cataloguing\additem.pl
Line 404 of tools\batchMod.pl
Line 418 of tools\batchMod.pl
Comment 2 Bernardo Gonzalez Kriegel 2014-05-02 22:05:27 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2014-05-02 22:08:26 UTC
Changed Bug description and component
Comment 4 Bernardo Gonzalez Kriegel 2014-05-03 22:25:16 UTC Comment hidden (obsolete)
Comment 5 Bernardo Gonzalez Kriegel 2014-05-03 22:29:06 UTC
*** Bug 682 has been marked as a duplicate of this bug. ***
Comment 6 Bernardo Gonzalez Kriegel 2014-05-03 22:32:02 UTC
(In reply to Owen Leonard from comment #1)
> I find these instances of the phrase "tag editor" in .pl and .pm files:
> 
> Line 238 of cataloguing\additem.pl
> Line 255 of cataloguing\additem.pl

This two in Bug 12176
Comment 7 Bernardo Gonzalez Kriegel 2014-05-04 02:11:05 UTC
(In reply to Owen Leonard from comment #1)
> I find these instances of the phrase "tag editor" in .pl and .pm files:
> 
> Line 220 of authorities\authorities.pl
> Line 252 of authorities\authorities.pl

This two in Bug 12177
Comment 8 Bernardo Gonzalez Kriegel 2014-05-04 17:34:08 UTC
(In reply to Owen Leonard from comment #1)
> I find these instances of the phrase "tag editor" in .pl and .pm files:
> 
> Line 404 of tools\batchMod.pl
> Line 418 of tools\batchMod.pl

This two in Bug 12180
Comment 9 Chris Cormack 2014-07-03 05:10:39 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall 2014-07-03 15:25:54 UTC
Created attachment 29492 [details] [review]
[PASSED QA] Bug 11638 - Remove HTML from addbiblio.pl

This patch extracts variables with HTML from addbiblio.pl
and an instance of CGI::scrolling_list

As it changes how MARC editor show input fields, I prefer
not add patches for other cases mentioned on Comment #1

To test:
1. Verify there are no regressions on MARC editor
Add/Edit records, modify values
2. Update translation file for a language,
check new string 'Tag editor'

About the error message on error when deleting biblio,
it must be localized but the script is not trying to
use a template file, only prints a basic html and aborts.
Perhaps a way of handling errors more gracefully is needed,
but again it need to be solved on it's own bug.

Updated test plan

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Tomás Cohen Arazi 2014-07-03 18:10:43 UTC
Patch pushed to master.

Thanks Bernardo!