To be consistent with overdue notices, HOLD_PRINT model should be formated in html and <br /> written directly in the letter. In this case, replacing carriage return with <br /> duplicates new lines in the final printed file.
Created attachment 28390 [details] [review] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices"
Created attachment 28503 [details] [review] [SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Exact reversion of 10727. Just thinking, again you will get all text in one line [1] [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727#c0
> Exact reversion of 10727. > Just thinking, again you will get all text in one line [1] Sounds like we are reverting a partial solution to get back a partial problem :) BTW: Should gather_print_notices not look at the content of each message before deciding to do a replace? The message could be plain text or html depending on the letter definition. Can we use this opportunity to come up with a more elegant solution? Perhaps you could ask Jonathan to assist here since this comes close to his work on message transport types.. Moving status to Failed QA.
Since Bug 11603 as been pushed, HOLD_PRINT is not used any more, there is no need of this patch