Bug 2546 removes the description DB field in some case (3.15.00.003). But the receipt generated by scripts members/printfeercpt.pl and members/printinvoice.pl display this field. When the description field is empty, the default value (based on accountlines.accounttype) should be displayed.
Created attachment 28835 [details] [review] Bug 12415: Fee receipt: a charges description should be displayed in all cases Bug 2546 removes the description DB field value in some case (3.15.00.003). But the receipt generated by scripts members/printfeercpt.pl and members/printinvoice.pl displays this field. When the description field is empty, the default value (based on accountlines.accounttype) should be displayed. Test plan: - Generate and pay some different kinds of fees for a patron without filling the 'description' field. - In Fines>Account, click on the 'print' link. - Before this patch, the "description of charges" values is empty if no description was given. It is a regression introduced by bug 2546, a default value was inserted in the description field depending on the account type selected. - After this patch, the "description of charges" values should be based on the account type. The string display on printing receipt should be the same as on the account screen (staff and opac). Note for QA: If removed the "payment" key, it is not used in template and generated a warning ("odd number of elements...").
I tested this and what I got is in the attached images. I see a description on the account tab, but when I go to print I see payment thanks 2 times - without the patch I see payment thanks 1 time - but I never see the full description that I see on the accounts tab.
Created attachment 28958 [details] account line
Created attachment 28959 [details] receipt for account line
(In reply to Nicole C. Engard from comment #3) > I tested this and what I got is in the attached images. I see a description > on the account tab, but when I go to print I see payment thanks 2 times - > without the patch I see payment thanks 1 time - but I never see the full > description that I see on the accounts tab. Hi Nicole, This means you have "Payment,Thanks" in one or more accountlines.description fields. The updatedb entry of bug 2546 should have removed them. Did you get error on updating your DB? Are you sure this updatedb entry have been executed?
(In reply to Jonathan Druart from comment #6) > Hi Nicole, > This means you have "Payment,Thanks" in one or more accountlines.description > fields. > The updatedb entry of bug 2546 should have removed them. > Did you get error on updating your DB? Are you sure this updatedb entry have > been executed? I'm never 100% sure about anything :) but I can tell you that all other things that have been fixed since then are updated in my db. So I have the new sys prefs and the new version number and many other updates to my db so I should have that one as well. I did a fresh fetch right before applying the patch. Nicole
I switch back to needs signoff to get some more feedbacks. The accountlines.description should not contain this string.
Hi Jonathan, I tested a bit and can recreate the doubled "Payment, Thanks" by simply partially paying a fine. For any payment that doesn't zero out the remaining balance the "Payment, Thanks" is added into accountlines.description. I also noted that manual credits show only 'C' in the receipt description if no other info is entered. -Nick
I am sorry but I cannot recreate. Could you please detail step by step or with screenshot/screencast?
Here was my test plan: 1 - Create a manual invoice - Lost Item, $5.00 2 - Pay fine partially, $2.50 3 - Switch to account tab - Payment, Thanks appears twice in description 4 - Check database via repot (SELECT * FROM accountlines WHERE borrowernumber=5) I tested again with a manual invoice - Fine and got the same results, zip of screenshots will be attached
Created attachment 31525 [details] Payment Thanks value entered into accountlines.description Sequential screenshots of how I got the error
Created attachment 31598 [details] [review] Bug 12415: Fee receipt: a charges description should be displayed in all cases Bug 2546 removes the description DB field value in some case (3.15.00.003). But the receipt generated by scripts members/printfeercpt.pl and members/printinvoice.pl displays this field. When the description field is empty, the default value (based on accountlines.accounttype) should be displayed. Test plan: - Generate and pay some different kinds of fees for a patron without filling the 'description' field. - In Fines>Account, click on the 'print' link. - Before this patch, the "description of charges" values is empty if no description was given. It is a regression introduced by bug 2546, a default value was inserted in the description field depending on the account type selected. - After this patch, the "description of charges" values should be based on the account type. The string display on printing receipt should be the same as on the account screen (staff and opac). Note for QA: If removed the "payment" key, it is not used in template and generated a warning ("odd number of elements...").
(In reply to Nick Clemens from comment #12) > Created attachment 31525 [details] > Payment Thanks value entered into accountlines.description > > Sequential screenshots of how I got the error Thanks, very useful! This should be fixed with the last patch.
Yep, I cannot recreate the 'Payment, Thanks' error I still notice that if I use the "Create Manual Credit" tab to add a credit type of either 'Credit' or 'Forgiven' the description on the receipt does not match the display in the account tab. For 'Credit' the receipt displays 'C' For 'Forgiven' the receipt displays 'FOR' Last notes may be beyond this bug: 1 - The 'description' field on the 'Create manual invoice' tab prefills to the type code for any type except 'Lost item' (i.e 'F' for fine, 'A' for 'Account manag...') It seems to me that with this patch there is no reason not to leave that field empty 2 - Copier fees description defaults to 'Copier fees' and the amount to "0.25" which is just an odd assumption unless that is configurable. Additionally, the account type for 'Copier Fees' shows as 'Copie' in both the accounts tab and on receipts. For English that should probably be either 'Copy' or stay with 'Copier fees'
Nick, What you described looks to be something else to fix. Maybe you could open a new bug report with the different issues listed.
Created attachment 31724 [details] [review] [SIGNED OFF] Bug 12415: Fee receipt: a charges description should be displayed in all cases Bug 2546 removes the description DB field value in some case (3.15.00.003). But the receipt generated by scripts members/printfeercpt.pl and members/printinvoice.pl displays this field. When the description field is empty, the default value (based on accountlines.accounttype) should be displayed. Test plan: - Generate and pay some different kinds of fees for a patron without filling the 'description' field. - In Fines>Account, click on the 'print' link. - Before this patch, the "description of charges" values is empty if no description was given. It is a regression introduced by bug 2546, a default value was inserted in the description field depending on the account type selected. - After this patch, the "description of charges" values should be based on the account type. The string display on printing receipt should be the same as on the account screen (staff and opac). Note for QA: If removed the "payment" key, it is not used in template and generated a warning ("odd number of elements..."). Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Other issues reported as Bug 12960 and Bug 12961
Created attachment 32377 [details] [review] [PASSED QA] Bug 12415: Fee receipt: a charges description should be displayed in all cases Bug 2546 removes the description DB field value in some case (3.15.00.003). But the receipt generated by scripts members/printfeercpt.pl and members/printinvoice.pl displays this field. When the description field is empty, the default value (based on accountlines.accounttype) should be displayed. Test plan: - Generate and pay some different kinds of fees for a patron without filling the 'description' field. - In Fines>Account, click on the 'print' link. - Before this patch, the "description of charges" values is empty if no description was given. It is a regression introduced by bug 2546, a default value was inserted in the description field depending on the account type selected. - After this patch, the "description of charges" values should be based on the account type. The string display on printing receipt should be the same as on the account screen (staff and opac). Note for QA: If removed the "payment" key, it is not used in template and generated a warning ("odd number of elements..."). Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This fixes the display of payments and other charges on the fines slip. Note: This patch fixes a line where the description in the database was still updated to say "Payment thanks" for partial payments. It might be worth to do a follow-up correcting the accountlines table and removing the unwanted comment (see bug 2546).
Created attachment 33800 [details] [review] Bug 12415: Fee receipt: a charges description should be displayed in all cases Bug 2546 removes the description DB field value in some case (3.15.00.003). But the receipt generated by scripts members/printfeercpt.pl and members/printinvoice.pl displays this field. When the description field is empty, the default value (based on accountlines.accounttype) should be displayed. Test plan: - Generate and pay some different kinds of fees for a patron without filling the 'description' field. - In Fines>Account, click on the 'print' link. - Before this patch, the "description of charges" values is empty if no description was given. It is a regression introduced by bug 2546, a default value was inserted in the description field depending on the account type selected. - After this patch, the "description of charges" values should be based on the account type. The string display on printing receipt should be the same as on the account screen (staff and opac). Note for QA: If removed the "payment" key, it is not used in template and generated a warning ("odd number of elements..."). Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This fixes the display of payments and other charges on the fines slip. Note: This patch fixes a line where the description in the database was still updated to say "Payment thanks" for partial payments. It might be worth to do a follow-up correcting the accountlines table and removing the unwanted comment (see bug 2546).
Rebased patch: The original patch included a typo fix in an opac prog template file that is no longer needed. Also checked bootstrap, the strings are already fixed there.
Patch pushed to master Thanks Jonathan!