Bug 12429 - patron seeing fines codes
Summary: patron seeing fines codes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: cgi-bin/koha/opac-account.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 13:08 UTC by Nicole C. Engard
Modified: 2015-06-04 23:30 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
FU showing in OPAC (50.89 KB, image/png)
2014-06-16 13:08 UTC, Nicole C. Engard
Details
Bug 12429 [staff client] patron seeing fines codes (4.26 KB, patch)
2014-06-27 18:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12429 [staff client] patron seeing fines codes (3.99 KB, patch)
2014-06-30 14:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12429 [OPAC] patron seeing fines codes (3.56 KB, patch)
2014-06-30 14:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12429 [staff client] patron seeing fines codes (4.00 KB, patch)
2014-07-01 05:03 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12429 [OPAC] patron seeing fines codes (3.57 KB, patch)
2014-07-01 05:03 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
[PASSED QA] Bug 12429 [staff client] patron seeing fines codes (4.07 KB, patch)
2014-07-06 20:12 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12429 [OPAC] patron seeing fines codes (3.64 KB, patch)
2014-07-06 20:13 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-06-16 13:08:06 UTC
Created attachment 28867 [details]
FU showing in OPAC

In the past the patron did not see the Fines code (FU, F, etc) - but they do now and it's confusing and a bit insulting in US English.  Can we have FU just say Fine or not appear at all to the public?
Comment 1 Owen Leonard 2014-06-27 17:12:20 UTC
Caused by Bug 2546 which attempts to anticipate every obscure undocumented account type code which Koha uses but fails to cover all of them:

        [% SWITCH line.accounttype %]
          [% CASE 'Pay' %]Payment,thanks
          [% CASE 'Pay00' %]Payment,thanks (cash via SIP2)
          [% CASE 'Pay01' %]Payment,thanks (VISA via SIP2)
          [% CASE 'Pay02' %]Payment,thanks (credit card via SIP2)
          [% CASE 'N' %]New Card
          [% CASE 'F' %]Fine
          [% CASE 'A' %]Account management fee
          [% CASE 'M' %]Sundry
          [% CASE 'L' %]Lost Item
          [% CASE 'W' %]Writeoff
          [% CASE %][% line.accounttype %]
        [%- END -%]

Kyle's list of codes includes these which are not in the above list:

FU = Fine that is currently accruing
Rent = Rental fee
FOR = Forgiven
LR = Lost item fee refund
PAY = Payment
WO = Writeoff
C = Credit
CR = Credit

I also see checks in the code for accounttypes 'O' and 'FN' but I haven't found any code which inserts those codes.
Comment 2 Owen Leonard 2014-06-27 18:23:40 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-06-30 14:03:11 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-06-30 14:20:22 UTC Comment hidden (obsolete)
Comment 5 Biblibre Sandboxes 2014-07-01 05:02:41 UTC
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Comment 6 Biblibre Sandboxes 2014-07-01 05:03:07 UTC Comment hidden (obsolete)
Comment 7 Biblibre Sandboxes 2014-07-01 05:03:10 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2014-07-06 20:12:45 UTC
Created attachment 29531 [details] [review]
[PASSED QA] Bug 12429 [staff client] patron seeing fines codes

Bug 2546 introduced translatable handling of Koha account type codes but
missed several codes. This patch adds handling of these codes to the
staff client.

This patch also corrects a couple of instances of incorrect
capitalization.

To test, apply the patch and view fines page (Patron details ->
Fines) and the pay fines page (Patron details -> Fines -> Pay fines).
You should not see any account type codes like CR, LR, or FU.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 9 Katrin Fischer 2014-07-06 20:13:01 UTC
Created attachment 29532 [details] [review]
[PASSED QA] Bug 12429 [OPAC] patron seeing fines codes

Bug 2546 introduced translatable handling of Koha account type codes but
missed several codes. This patch adds handling of these codes to the
bootstrap OPAC.

This patch also corrects a couple of instances of incorrect
capitalization.

To test, apply the patch and log in to the OPAC as a user who has
existing fines and charges. View the "Your fines" page. You should not
see any account type codes like CR, LR, or FU.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2014-07-07 15:44:51 UTC
Patches pushed to master.

Thanks Owen!
Comment 11 Nicole C. Engard 2014-07-24 17:14:49 UTC
Are there any plans for this to be in 3.16.x?
Comment 12 Barton Chittenden 2014-07-28 21:15:14 UTC
Couple of small issues still need to be addressed:

* The code 'FFOR' is still not expanded.
* There is a space between the fine decription and the following comma, so

  Fine , To kill a mockingbird / 10/23/2013 23:59  View item To kill a mockingbird /

should read

  Fine, To kill a mockingbird / 10/23/2013 23:59  View item To kill a mockingbird /
Comment 13 Galen Charlton 2014-09-23 04:46:12 UTC
Pushed to 3.16.x for inclusion in 3.16.4.