Bug 12957 - Get rid of warning in aqbudgets.pl
Summary: Get rid of warning in aqbudgets.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-18 10:56 UTC by Jonathan Druart
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12957: Get rid of warnings in aqbudgets.pl (3.81 KB, patch)
2014-09-18 10:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12957: Get rid of warnings in aqbudgets.pl (3.92 KB, patch)
2014-10-10 14:31 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12957: Get rid of warnings in aqbudgets.pl (4.00 KB, patch)
2014-10-11 21:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-09-18 10:56:28 UTC
There are a lot of warnings on navigating into the fund views (list, editing, etc.)

"Use of uninitialized value in string eq..."

"Use of uninitialized value in hash element"

"Use of uninitialized value in concatenation..."
Comment 1 Jonathan Druart 2014-09-18 10:59:06 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-10-10 14:31:46 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-11 21:36:58 UTC
Created attachment 32278 [details] [review]
[PASSED QA] Bug 12957: Get rid of warnings in aqbudgets.pl

There are a lot of warnings on navigating into the fund views (list,
editing, etc.)

"Use of uninitialized value in string eq..."
"Use of uninitialized value in hash element"
"Use of uninitialized value in concatenation..."

Test plan:
Verify the warnings don't appear anymore in logs on going on the fund
list view, editing a fund, saving a fund.

QA note: the budget_owner_name, budget_borrowernumber and branchname are
never used on the fund list view. A call to GetMember has been removed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This seems to work nicely reducing the amount of noise in the log
considerably.
Comment 4 Tomás Cohen Arazi 2014-10-15 16:00:09 UTC
Patch pushed to mater.

Thanks Jonathan!