If sortby is not set and left as undefined, there are a bunch of noisy errors
Created attachment 38624 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log
Comment on attachment 38624 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc Review of attachment 38624 [details] [review]: ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ +18,4 @@ > > use strict; > use warnings; > +use lib '.'; Why this addition?
(In reply to M. Tompsett from comment #2) > Comment on attachment 38624 [details] [review] [review] > Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc > > Review of attachment 38624 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: C4/AuthoritiesMarc.pm > @@ +18,4 @@ > > > > use strict; > > use warnings; > > +use lib '.'; > > Why this addition? Oops forgot to take that out when I was experimenting earlier! My bad
Created attachment 38626 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log
Comment on attachment 38626 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc Review of attachment 38626 [details] [review]: ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ -18,4 @@ > > use strict; > use warnings; > -use lib '.'; Now you lost your change, because you obsoleted the other patch.
(In reply to M. Tompsett from comment #5) > Comment on attachment 38626 [details] [review] [review] > Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc > > Review of attachment 38626 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: C4/AuthoritiesMarc.pm > @@ -18,4 @@ > > > > use strict; > > use warnings; > > -use lib '.'; > > Now you lost your change, because you obsoleted the other patch. Of course oops my mistake again,thanks for fixing that
Created attachment 38628 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I would have done $sortby //= ''; But this works too. :)
Created attachment 38660 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I would have done $sortby //= ''; But this works too. :) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Aleisha!
Pushed to 3.18.x will be in 3.18.7
Pushed to 3.16.x, will be in 3.16.11