Bug 14601 - Cardnumber should not be required for patron import
Summary: Cardnumber should not be required for patron import
Status: RESOLVED DUPLICATE of bug 23077
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-24 16:20 UTC by Danielle Elder
Modified: 2020-01-07 23:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Danielle Elder 2015-07-24 16:20:37 UTC
When importing patrons, cardnumber should not be a required field as it can be NULL. 

This happens if you are matching or not when importing.
Comment 1 Katrin Fischer 2015-07-25 22:26:18 UTC
Hi Danielle, while the cardnumber can be null in the database I think it at least used to create a lot of problems in other places. I'd really hesitate to make it optional without some more research and testing first.
Comment 2 Katrin Fischer 2015-07-28 21:44:22 UTC
I researched a bit and found 2 bugs about patrons without cardnumbers: bug 14562, bug 13780

I can imagine it might also cause problems if hidepatronname is used - as that will show the cardnumber as the only information on the patron record and link it. But haven't tested that.
Comment 3 Danielle Elder 2015-08-03 17:29:24 UTC
Well, it's not so much that they don't want to add a cardnumber as it is they don't want to overwrite it.

A lot of universities update patron data every semester with data from the school.  The particular workflow it to import patrons from university data, with a populated cardnumber (same as attribute value (unique - college id).

Then student comes into library to get a library-issued cardnumber and that borrower record is updated with that value. 

They want to, after that, be able to update patron data matching on the attribute (college id) for future semesters .... but if the cardnumber is required, that would be overwritten and the library-isssued cardnumber disappears.  Usually you can make updates by only including the columns you want to change and leaving columns out you don't want to update.
Comment 4 Katrin Fischer 2015-08-03 17:42:06 UTC
Hm, I understand - we have a library requesting something similar. We currently restore the cardnumbers with SQL after importing, which works but is not a good solution. I think another way to make this work could be a 'don't update if not empty' flag for the import or something similar?

We could also make the cardnumber optional, but I think we'd have quite a few libraries run into the mentioned bugs then. Not sure what's best.
Comment 5 Danielle Elder 2015-08-04 16:57:48 UTC
Can the cardnumber just be optional with the overwrite option?
Comment 6 Jonathan Druart 2015-08-05 09:05:32 UTC
CCing Stéphane,
I would like to get your opinion on this point.
Do you have the same problem when you migrate/import patrons to Koha?
Comment 7 Danielle Elder 2015-09-02 18:35:27 UTC
(In reply to Jonathan Druart from comment #6)
> CCing Stéphane,
> I would like to get your opinion on this point.
> Do you have the same problem when you migrate/import patrons to Koha?

This is a real problem as the library wants to update several times a semester.
Comment 8 Danielle Elder 2015-09-02 18:44:32 UTC
Katrin I read the bugs mentioned about missing cardnumber or empty string and that would not be the case here. That patrons have cardnumbers already, we just don't want to overwrite the existing cardnumber when importing/overwriting based on a unique attribute (university ID) and want to leave out the cardnumber column.
Comment 9 Katrin Fischer 2020-01-07 23:05:18 UTC

*** This bug has been marked as a duplicate of bug 23077 ***