We say 'branchcode' and 'categorycode' are required - this is true, but so are surname and cardnumber
Created attachment 65363 [details] [review] Bug 19012 - Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable
Created attachment 65693 [details] [review] [SIGNED OFF] Bug 19012 - Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
No, they are not mandatory. It's the default value for BorrowerMandatoryField, but can be removed, and others can be added. I guess you will have to parse the pref to display which fields are mandatory.
That's interesting, I didn't know that!
Hm, in my experience surname and cardnumber were always needed and it seemed to make sense, now I wonder.
I'd done some testing and looking at the code, surname is a mandatory hardcoded value: 150: my @criticals = qw(surname branchcode categorycode); # there probably should be others Cardnumber in fact isn't!
Created attachment 90419 [details] [review] Bug 19012 - Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable
*** Bug 20671 has been marked as a duplicate of this bug. ***
(In reply to Jonathan Druart from comment #3) > No, they are not mandatory. It's the default value for > BorrowerMandatoryField, but can be removed, and others can be added. I guess > you will have to parse the pref to display which fields are mandatory. Nope, test it, fields required in the pref are not required for import - that may be its own bug if you wish
Created attachment 90708 [details] Really Spare Patron Import. This is a scary example of what patron import let's you import. I suspect if you had userid set and empty card number and used userid as the match, it would import too.
I got away with cardnumber, branch code, and category code. If we are correcting the text to match what it does, then the text is still wrong. If we are fixing the import and matching the text, then that's still broken.
Created attachment 90721 [details] Really realy spare patron import Remove surname from the file and it fails on missing a critical column
Created attachment 90856 [details] [review] Bug 19012 - Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 91328 [details] [review] Bug 19012: Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
backported to 18.11.x for 18.11.09