Bug 15136 - Display item's homebranch in patron's fines list
Summary: Display item's homebranch in patron's fines list
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Vassilis Kanellopoulos
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 21462
  Show dependency treegraph
 
Reported: 2015-11-05 10:54 UTC by Vassilis Kanellopoulos
Modified: 2020-01-06 20:15 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
add homebranch of borrowed items (3.84 KB, patch)
2015-11-09 09:56 UTC, Vassilis Kanellopoulos
Details | Diff | Splinter Review
add homebranch of borrowed items (3.84 KB, patch)
2015-11-09 11:25 UTC, Vassilis Kanellopoulos
Details | Diff | Splinter Review
Add homebranch of borrowed items to patron accounts tab (4.13 KB, patch)
2015-11-09 22:11 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15136: Add homebranch of borrowed items to patron accounts tab (4.16 KB, patch)
2015-11-10 09:01 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15136: Use TT plugin to display the branch's name (2.31 KB, patch)
2015-11-10 09:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15136: Add homebranch of borrowed items to patron accounts tab (4.34 KB, patch)
2018-02-13 17:15 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15136: Use TT plugin to display the branch's name (2.35 KB, patch)
2018-02-13 17:15 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15136: Add homebranch of borrowed items to patron accounts tab (2.78 KB, patch)
2018-06-16 02:02 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15136: Add homebranch of borrowed items to patron accounts tab (2.87 KB, patch)
2018-06-22 20:33 UTC, Maryse Simard
Details | Diff | Splinter Review
Bug 15136: Add homebranch of borrowed items to patron accounts tab (2.95 KB, patch)
2018-07-20 16:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15136: (follow-up) Fix 'Filter paid transactions' button (1.11 KB, patch)
2018-10-01 12:43 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Vassilis Kanellopoulos 2015-11-05 10:54:33 UTC
Displaying the item's homebranch for item in "Description of charges" would be useful.
Comment 1 Vassilis Kanellopoulos 2015-11-05 10:57:59 UTC
I've submitted a pull request for this enhancement. 

https://github.com/Koha-Community/Koha/pull/10
Comment 2 Katrin Fischer 2015-11-08 18:07:28 UTC
Hi Vassilis, 

thx for your contribution! Can you please attach a patch file to this bug? The Koha community is not using github pull requests in its development workflow.

Some additional information can be found on the wiki:
http://wiki.koha-community.org/wiki/Development_workflow
http://wiki.koha-community.org/wiki/SubmitingAPatch
Comment 3 Vassilis Kanellopoulos 2015-11-09 09:56:24 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2015-11-09 10:20:16 UTC
Thx Vassilis! Once the patch file is attached, you can switch the bug status to "Needs Signoff". This way it shows up on the queues for things to be tested.
One tiny thing about your patch: 

+          <th>Item Homebranch</th>
We only have the first term in capitals, also please check the term we use in the normal item view or in the checkouts list for comparison.
Comment 5 Vassilis Kanellopoulos 2015-11-09 11:25:41 UTC Comment hidden (obsolete)
Comment 6 Vassilis Kanellopoulos 2015-11-09 11:28:38 UTC
Thanks Kartin. I've changed table heading.
Comment 7 Nick Clemens 2015-11-09 22:11:53 UTC Comment hidden (obsolete)
Comment 8 Nick Clemens 2015-11-09 22:14:35 UTC
Hi Vassilis,

I signed off, works as expected.  I added a test plan to the commit message, you should always include one with the patch submission to make testing easier 
(and so you can be sure that you and the tester agree on what the results should be :-) )

-Nick
Comment 9 Vassilis Kanellopoulos 2015-11-10 00:17:03 UTC
(In reply to Nick Clemens from comment #8)
> Hi Vassilis,
> 
> I signed off, works as expected.  I added a test plan to the commit message,
> you should always include one with the patch submission to make testing
> easier 
> (and so you can be sure that you and the tester agree on what the results
> should be :-) )
> 
> -Nick

Hi Nick,

Thanks for the advice. It's my first contribution to Koha and I'm still learning the process.
Comment 10 Jonathan Druart 2015-11-10 09:01:27 UTC
Created attachment 44681 [details] [review]
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2015-11-10 09:02:08 UTC
Created attachment 44682 [details] [review]
Bug 15136: Use TT plugin to display the branch's name

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Vassilis Kanellopoulos 2016-02-23 08:48:31 UTC
Why the patch doesn't apply? Please reason.
Comment 13 Katrin Fischer 2016-02-23 09:03:50 UTC
It means that it can't be applied with git - it needs to be rebased to fit with the current codebase.
Comment 14 Vassilis Kanellopoulos 2016-02-23 09:36:35 UTC
OK. So I' ll rebase and submit the patch again. Thanks.
Comment 15 Katrin Fischer 2016-02-23 09:42:20 UTC
If it's a simple rebase, you can switch it back to "Passed QA" after. If it's more complicated, please switch to "Needs Sign-off" again.
Comment 16 Nick Clemens 2018-02-13 17:15:14 UTC
Created attachment 71559 [details] [review]
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 17 Nick Clemens 2018-02-13 17:15:17 UTC
Created attachment 71560 [details] [review]
Bug 15136: Use TT plugin to display the branch's name

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 18 Jonathan Druart 2018-02-13 17:21:33 UTC
Nick:

             $data->{title}        = $biblio->title;
+            $data->{homebranch}   = $biblio->{homebranch};

This reads wrong.

Moreover GetMemberAccountRecords will be removed by bug 12001.
Comment 19 Nick Clemens 2018-06-16 02:02:36 UTC
Created attachment 76112 [details] [review]
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column
Comment 20 Maryse Simard 2018-06-22 20:33:46 UTC
Created attachment 76308 [details] [review]
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.
Comment 21 Jonathan Druart 2018-07-20 16:42:43 UTC
Created attachment 77174 [details] [review]
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 22 Nick Clemens 2018-08-10 12:55:41 UTC
Awesome work and congratulations on your first patch Vassilis!

Pushged to master for 18.11
Comment 23 Martin Renvoize 2018-08-10 13:29:59 UTC
Enhancement, won't be backported to 18.05.x series.
Comment 24 Johan Larsson 2018-10-01 12:24:19 UTC
After the new column with homebranch was added the button for "filter paid transactions" does not work. 

The code that should be adjusted is:
table_account_fines.fnFilter(filteredValue, 4, true, false);

it should now be 
table_account_fines.fnFilter(filteredValue, 5, true, false);
Comment 25 Johan Larsson 2018-10-01 12:42:44 UTC
Will open new bug
Comment 26 Nick Clemens 2018-10-01 12:43:57 UTC
Created attachment 79711 [details] [review]
Bug 15136: (follow-up) Fix 'Filter paid transactions' button
Comment 27 Johan Larsson 2018-10-01 13:04:48 UTC
New bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
Comment 28 Jonathan Druart 2018-10-01 16:25:24 UTC
Comment on attachment 79711 [details] [review]
Bug 15136: (follow-up) Fix 'Filter paid transactions' button

Moved to bug 21462