Bug 15566 - Update API to allow to reserve first available item from a group of titles
Summary: Update API to allow to reserve first available item from a group of titles
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on: 15516 13903
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-13 13:20 UTC by Julian Maurice
Modified: 2017-01-27 10:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 15566: API - allow to reserve first available from a group of titles (12.08 KB, patch)
2016-02-29 12:42 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15566: API - allow to reserve first available from a group of titles (12.20 KB, patch)
2016-04-08 22:54 UTC, Benjamin Rokseth
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2016-01-13 13:20:07 UTC
Bug 15516 will bring the ability to reserve the first available item from a group of titles. The API should allow that too.
Comment 1 Julian Maurice 2016-02-29 12:42:08 UTC Comment hidden (obsolete)
Comment 2 Benjamin Rokseth 2016-04-08 22:54:54 UTC
Created attachment 50097 [details] [review]
Bug 15566: API - allow to reserve first available from a group of titles

Test plan:
0. Find 1 borrower and 2 biblios they can place a hold on. Let's call
   them $borrowernumber, $biblionumber1 and $biblionumber2
1. Make a POST request to http://your.library.org/api/v1/reserves with
   the following body:
     {
       "onlyfirst": true,
       "reserves": [
         {
           "borrowernumber": $borrowernumber,
           "biblionumber": $biblionumber1
         },
         {
           "borrowernumber": $borrowernumber,
           "biblionumber": $biblionumber2
         },
       ]
     }
2. Check that you get a 201 response with the reserves informations
3. Check in staff interface that the reserves were correctly made

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Comment 3 Benjamin Rokseth 2016-04-08 22:58:31 UTC
Rebased against master.

Any reason this is blocked? Tests pass and API seems fine, although its certainly gonna conflict with Bug 15567 - Update API to allow multiple holds for the same record, at least the code in Koha/REST/V1/Reserve.pm and the definition files
Comment 4 Julian Maurice 2016-04-18 07:06:24 UTC
I don't remember why I changed the status to BLOCKED. All dependencies are Signed Off, so we can change it back to Needs Signoff
Comment 5 Benjamin Rokseth 2016-04-19 13:56:30 UTC
As I already signed off this one and tested it ok, I see no reason it shouldn't move on to QA
Comment 6 Marcel de Rooy 2016-07-22 06:12:29 UTC
Depends on a PNA patch
Comment 7 claire.hernandez@biblibre.com 2016-09-16 14:00:17 UTC
If PNA is like DNA, I think I can unblocked it.
Comment 8 Marcel de Rooy 2017-01-27 10:02:45 UTC
Blocked: this depends on a failed qa report.