Bug 15718 - Need more information for items that don't successfully batch checkout
Summary: Need more information for items that don't successfully batch checkout
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 11759 15920
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-01 20:32 UTC by HB-NEKLS
Modified: 2016-12-01 21:58 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
batch checkout failed list (37.93 KB, image/png)
2016-02-01 20:32 UTC, HB-NEKLS
Details

Note You need to log in before you can comment on or make changes to this bug.
Description HB-NEKLS 2016-02-01 20:32:24 UTC
Created attachment 47530 [details]
batch checkout failed list

I'm testing the new batch checkout feature in 3.22, and am trying to throw every possible non-standard status at it to see if it hiccups. So far, so good. 

If an item won't check out because it's of a non-loanable item type or not for loan status or over a circ rule threshold, the batch checkout screen displays somewhat helpful text for why something won't batch check out. 

However, after you've pressed the confirm Checkout button, if items cannot be be checked out due to different reasons, the list of non-checked out items displays on the screen, but you aren't told anywhere on the screen that these are the items that DIDN'T check out in the batch check out process. The information column that had populated on the previous screen is now blank. (see attached screenshot)

To recreate: 
1. Enable batch checkout and applicable patron categories

2. Using a patron with a category set in step 1, attempt to batch checkout several materials, including two materials that wouldn't normally check out anyway (example: not for loan status or non-loanable item type, or over checkout limit numbers). 

3. Once the items are submitted for batch checkout, note that (at least) two items that can't be checked out have information listed in the information column.

4. Confirm the batch checkouts.

5. Note that the screen that appears does not indicate the item list is for those that failed the batch checkout process.
Comment 1 Jonathan Druart 2016-02-04 09:02:14 UTC
To explain:

I have checked out
my_barcode_981 #not for loan
FDSQQSDFQSD    # does not exist
my_barcode_9810
my_barcode_9810

On the first screen, I get:
Batch checkout confirmation for Joubu (42)
    Barcode             Title                                   Information
[x] my_barcode_981 	my_title_98, by donald my_barcode_981 	Item is normally not for loan .
    FDSQQSDFQSD                                                 The barcode was not found FDSQQSDFQSD
    00113102951663 	Une cuisine grande comme le monde 00113102951663 	
[x] my_barcode_9810 	my_title_98, by donald my_barcode_9810 	Too many checked out.

Please confirm checkout

Line 3 (00113102951663) has been checked out at this point
Line 2 is not selectable: the barcode does not exist.
So yes, for the next step, we will process only the 2 items that have failed (we force the checkout).

On the next screen, we will get:

Barcode 	Title 	Information
my_barcode_981 	my_title_98, by donald my_barcode_981
my_barcode_9810 	my_title_98, by donald my_barcode_9810


I agree it's not obvious, but I don't know what I could do to clarify the screen.
Any suggestions?
Comment 2 HB-NEKLS 2016-02-04 12:41:44 UTC
Johnathan, what about something as simple as adding a table title for that screen, "items that didn't check out" or in the information column for each item, "item didn't check out?"

Is that possible?
Comment 3 Jonathan Druart 2016-02-19 15:51:37 UTC
(In reply to Heather Braum from comment #2)
> Johnathan, what about something as simple as adding a table title for that
> screen, "items that didn't check out" or in the information column for each
> item, "item didn't check out?"
> 
> Is that possible?

(almost) Everything is possible :)
I agree there is an ergonomic issue, the different screens are not obvious about what has been done and what will be done on the next screen.

I have cced Katrin, Nicole and Owen to get more ideas.
Comment 4 Katrin Fischer 2016-02-23 22:04:07 UTC
I didn't test this feature much so far, but after a quick test I think a table header as suggested by Heatzer might help to make things clearer.
Comment 5 Héctor Eduardo Castro Avalos 2016-02-26 19:38:34 UTC
Hi all

I've tested this feature in bug 15920 and gave me some errors. See comments and the images attached to it.

Regards
Comment 6 Jonathan Druart 2016-02-29 13:46:18 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #5)
> Hi all
> 
> I've tested this feature in bug 15920 and gave me some errors. See comments
> and the images attached to it.
> 
> Regards

Could you open a new bug report for that bug issue please?
Comment 7 Jonathan Druart 2016-02-29 13:50:37 UTC
Heather, Owen has submitted a patch on bug 15920 to clarify the display of the warnings/errors. I'd like you to have a look at this patch, then suggest me something if you think we need additional clarification.
Comment 8 Héctor Eduardo Castro Avalos 2016-02-29 15:59:44 UTC
(In reply to Jonathan Druart from comment #6)

> Could you open a new bug report for that bug issue please?

Hi Jonathan

I filed bug 15937 and included you in the bug mail

Regards
Comment 9 HB-NEKLS 2016-02-29 16:40:09 UTC
Jonathan, 

Just tried to test batch checkout on BibLibre's sandbox #8 for bug 15920 like you asked, and i’m getting this error, “Software error:

No branchcode argument passed to Koha::Calendar->new at /home/koha/src/C4/Circulation.pm line 3528
For help, please send mail to the webmaster (webmaster@test8-sandbox), giving this error message and the time and date of the error.”

It happened when I only had master on the system and when I had applied bug 15920. 

The barcode set I was using to checkout was: 
3999900000001
3999900000002
3999900000015
3999900000016
3999900000017
3999900000018
3999900000019
3999900000020
3999900000021
39999000000238
39999000000252
1

And I was checking out to Harry Crawford (29999000000348).

Calendar looked to be set?
Comment 10 Jonathan Druart 2016-03-02 08:22:24 UTC
(In reply to Heather Braum from comment #9)
> Jonathan, 
> 
> Just tried to test batch checkout on BibLibre's sandbox #8 for bug 15920
> like you asked, and i’m getting this error, “Software error:
> 
> No branchcode argument passed to Koha::Calendar->new at
> /home/koha/src/C4/Circulation.pm line 3528
> For help, please send mail to the webmaster (webmaster@test8-sandbox),
> giving this error message and the time and date of the error.”

It seems that at least 1 item does not have a holdingbranch defined, it's another bug.