Bug 15846 - Move MARC Framework JavaScript into separate file
Summary: Move MARC Framework JavaScript into separate file
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-17 16:48 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15846 - Move MARC Framework JavaScript into separate file (9.89 KB, patch)
2016-02-17 16:59 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15846: Move MARC Framework JavaScript into separate file (9.98 KB, patch)
2016-02-17 17:13 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15846: Move MARC Framework JavaScript into separate file (10.08 KB, patch)
2016-02-29 13:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15846: Move MARC Framework JavaScript into separate file (10.05 KB, patch)
2016-03-24 12:44 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-17 16:48:34 UTC
Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates) says "Whenever possible JavaScript should be placed in a separate file."

The JavaScript embedded in admin/biblio_framework.tt is not so dependent on template processing that it can't be safely moved to a separate file.
Comment 1 Owen Leonard 2016-02-17 16:59:38 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-02-17 17:13:30 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-02-29 13:49:23 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2016-02-29 13:50:40 UTC
I fixed the merge problem and have returned this to "signed off." This page is affected by Bug 15916, so you may need that patch to test this properly.
Comment 5 Katrin Fischer 2016-03-24 06:11:01 UTC
Please rebase!
Comment 6 Owen Leonard 2016-03-24 12:44:43 UTC
Created attachment 49528 [details] [review]
Bug 15846: Move MARC Framework JavaScript into separate file

The JavaScript embedded in the MARC framework template is not
dependent on template processing to such an extent that it can't
be safely moved to a separate file. This patch does so, adding
definition of a few translatable strings to the template.

To test, apply the patch and go to Administration -> MARC frameworks.

- The table of existing frameworks should be sortable.
- The "Export" link should trigger the export modal.
- The "Import" link should trigger the import modal.
  -- Clicking "Import" without selecting a file should trigger an alert.
  -- Selecting the wrong file type should trigger an alert.
  -- Importing a file of the correct type should trigger an overwrite
     warning ("Do you really want to import...?").
  -- A progress indicator should show during the import, with correct
     values for "Importing from" and "Importing to".
  -- Importing an incorrectly-formatted file of a correct type should
     trigger an alert, "Error importing the framework..."

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Export and Import options work properly
Comment 7 Jesse Weaver 2016-03-24 21:28:10 UTC
Will be in the May 2015 release, thanks for your work!