Bug 16022 - Use Font Awesome icons on patron lists page
Summary: Use Font Awesome icons on patron lists page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/patron_lists/lists.pl
Keywords:
Depends on: 14131
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-09 14:41 UTC by Owen Leonard
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16022 - Use Font Awesome icons on patron lists page (2.20 KB, patch)
2016-03-09 14:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16022 - Use Font Awesome icons on patron lists page (2.22 KB, patch)
2016-03-09 16:07 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 16022 - Use Font Awesome icons on patron lists page (2.30 KB, patch)
2016-03-10 11:50 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-09 14:41:09 UTC
There is one place on the patron lists page where a Glyphicon is used. It should be replaced with a Font Awesome icon.
Comment 1 Owen Leonard 2016-03-09 14:44:58 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-09 16:07:38 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 11:50:25 UTC
Created attachment 48948 [details] [review]
Bug 16022 - Use Font Awesome icons on patron lists page

The patron lists page had one stray instance of a Glyphicon class
instead of Font Awesome. This patch corrects it.

To test, apply the patch and go to Tools -> Patron lists.

In the list of patron lists, confirm that the "Actions" menu displays
the correct icon for "Print patron cards" and that the function of the
menu item is correct.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-11 21:54:52 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!
Comment 5 Julian Maurice 2016-03-14 09:50:49 UTC
Does not concern stable versions, status changed to RESOLVED