The patron card creator allows to print batches from it's own batch functionality. It would be very useful if it could export patron cards from patron lists as well.
Created attachment 38792 [details] [review] Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF
When attempting to create a patron list (running master), I receive an error which states: "An error occurred." See the attached screenshot.
Created attachment 38875 [details] Error when attempting to build a patron list This may be a tangential bug not directly related to this enhancement, but I'll wait for confirmation before opening a separate bug report.
Created attachment 38876 [details] Error when attempting to build a patron list And now the shot with the error showing...
(In reply to Chris Nighswonger from comment #3) > Created attachment 38875 [details] > Error when attempting to build a patron list > > This may be a tangential bug not directly related to this enhancement, but > I'll wait for confirmation before opening a separate bug report. I just re-tested on current master, I could create patron lists from patron search with and without patch. Additonally, this pach does not touch creating of patron lists but uses existing patron lists.
Still applies.
*** Bug 12471 has been marked as a duplicate of this bug. ***
Created attachment 42491 [details] [review] Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
This is a really useful improvement - thanks. I have 2 comments: There is a small typo in the patch. See line 54 in print.tt. [% IF ( borrower_count == 1 ) %]Exporting [% borrower_count %] patroncard[% ELSE %]Exporting [% borrower_count %] patroncards[% END %]a The "a" at the end is incorrect. The feature has been added to the Patron Card Creator tool which is where cards are normally created but the functionality is very oriented towards batches and in this case there is no batch. This may be a little quirky for the user. They have to go to "Manage batches" in order to export a list. Can I suggest a few options? - Describe this feature in the home page of the module - Add a link on the left, e.g."Export list" - In the Patron Lists module, add an "Export cards" button in the table of Patron Lists and then, in the list itself allow the user to select some borrowers and "Export cards" for those selected. The Export button on the patron list table could be done with the following changes to patron_lists/lists.tt: Add: [% INCLUDE 'greybox.inc' %] Modify the table sorting: { "aTargets": [ -1, -2, -3, -4 ], "bSortable": false, "bSearchable": false }, Add export column: <td> <a class="btn btn-mini" href="#" onclick='GB_showCenter(_("Export patron cards from list"), "/cgi-bin/koha/patroncards/print.pl?patronlist_id=[% l.patron_list_id %]", 700, 800);return false;'> <i class="icon-print"></i> Export cards </a> </td> I know this is not the complete solution as the grey box does not have a Done button. I will investigate how to become a contributor to Koha but wanted to make this suggestion while I work on that.
(In reply to Pete Edwards from comment #9) > I will investigate how to become a contributor to Koha but wanted to make > this suggestion while I work on that. Hi Pete, Did you plan to provide a patch? See the wiki pages http://wiki.koha-community.org/wiki/SubmitingAPatch and http://wiki.koha-community.org/wiki/Version_Control_Using_Git
Created attachment 42821 [details] [review] [Follow-up]Bug 14131 - Fix typo in print.tt Superfluous 'a' removed in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt line 54 (See comment #9) -MV
Hi Pete, Thanks for pointing out the typo and thanks for your suggestions as well. I propose to use my patch(es) 'as is' and to open a new bug to enhance / embellish this feature. Marc
I join the opinion of Pete, there is an ergonomic issue, I don't think the new "export from patron list" enhancement is correctly placed. I let another QAer have a look at your patch and give his/her feedback.
Created attachment 43414 [details] [review] Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF Modified patch to work with Bug 14676 changes. Functionality unchanged. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Liz <wizzyrea@gmail.com>
Hm, I could possibly look after the ergonomic things once both this and 14676 are upstream, because the suggestions would only apply on the current UI.
Created attachment 43415 [details] [review] Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work.
What is the state of this one? Does the ergonomic issue fixed?
The ergonomic change I added will probably want testing on top of this patch. The modified patch I did for compatibility with 14676 is likely ok, but if you're gonna test the one, you'll have to have the other(s) anyway. Note that the two I've uploaded will need to be applied on top of 14676.
Created attachment 43544 [details] [review] Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 43805 [details] [review] Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 43806 [details] [review] Bug 14131: Reduce the greybox height to 400px Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
The display looks better on my screens (15" and 26"), 800 is definitely too much.
... with the last patch!
Jonathan, do you think we should change the height on that greybox across the board for the label and patron card creators? It kinda feels like the right thing to do. Liz
(In reply to Liz Rea from comment #24) > Jonathan, do you think we should change the height on that greybox across > the board for the label and patron card creators? > > It kinda feels like the right thing to do. > > Liz Indeed, to be consistent it would be good to reduce them too.
cool I'll probably have a poke at that one unless you've already started on it.
(In reply to Liz Rea from comment #26) > cool I'll probably have a poke at that one unless you've already started on > it. I don't :)
Created attachment 45634 [details] [review] Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF Modified patch to work with Bug 14676 changes. Functionality unchanged. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Liz <wizzyrea@gmail.com> (Amended to make it apply on current master)
Created attachment 45635 [details] [review] Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45636 [details] [review] Bug 14131: Reduce the greybox height to 400px Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I amended the first patch to make it apply and then re-uploaded the following patches (unchanged) to keep them in the right order, I hope that is OK.
Pushed to Master - thanks