Bug 16051 - Styling buttons in stage MARC records for import
Summary: Styling buttons in stage MARC records for import
Status: RESOLVED DUPLICATE of bug 16100
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic record staging/import (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-11 00:33 UTC by Aleisha Amohia
Modified: 2016-03-24 15:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16051: Styling buttons (2.11 KB, patch)
2016-03-11 00:35 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-11 00:33:08 UTC
tools/stage-marc-import.pl uses different styles of buttons on the same page and it looks a bit silly
Comment 1 Aleisha Amohia 2016-03-11 00:35:52 UTC
Created attachment 48984 [details] [review]
Bug 16051: Styling buttons

This patch styles all the buttons with <button> tags and font awesome classes.

Buttons to test/confirm on tools/stage-marc-import.pl:

-Upload file button
-Cancel button (which shows up in the place of Upload file when you click it)
-Stage for import button (which shows up once your file has uploaded)

Sponsored-by: Catalyst IT
Comment 2 Marc Véron 2016-03-24 14:27:40 UTC
(In reply to Aleisha Amohia from comment #1)
> Created attachment 48984 [details] [review] [review]
> Bug 16051: Styling buttons
(...)
> ...and font awesome classes.
(...)

Works OK, but no font awsome found, is that intended?
Comment 3 Owen Leonard 2016-03-24 14:53:29 UTC
I think Bug 16100 fixes this bug by making non-Bootstrap <button> elements consistent with other submit buttons.
Comment 4 Marc Véron 2016-03-24 15:28:27 UTC
(In reply to Owen Leonard from comment #3)
> I think Bug 16100 fixes this bug by making non-Bootstrap <button> elements
> consistent with other submit buttons.

Oh, I even signed off on Bug 16100 :-)

Setting this one to duplicate.

*** This bug has been marked as a duplicate of bug 16100 ***