Bug 16100 - Buttons in patron toolbar are styled differently
Summary: Buttons in patron toolbar are styled differently
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
: 16051 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-03-18 00:20 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16100: Styling patron toolbar buttons the same (1.51 KB, patch)
2016-03-18 00:21 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16100 [Alternate] Buttons in patron toolbar are styled differently (3.11 KB, patch)
2016-03-18 13:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16100 [Alternate] Buttons in patron toolbar are styled differently (3.29 KB, patch)
2016-03-21 10:15 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16100 [Alternate] Buttons in patron toolbar are styled differently (3.35 KB, patch)
2016-03-23 20:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-18 00:20:00 UTC
the New patron button and Patron lists button in patron-toolbar.inc are styled differently and look silly next to each other
Comment 1 Aleisha Amohia 2016-03-18 00:21:34 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-03-18 13:21:12 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-03-18 13:23:32 UTC
Aleisha I'm glad you took this up, because it was bugging me too and I couldn't figure out what was causing it. Having now done some more digging I think we can fix this with CSS changes rather than markup changes.
Comment 4 Mark Tompsett 2016-03-20 17:50:04 UTC
The questions in my mind before I decide what to sign off would be:
1) Are we going to have 'button' for sublists and 'a' for single action items? Should we even care?
2) The CSS styling, what other pages might it affect?

Because for (1), it seems strange to me to use 'a' to trigger the sublist, but perhaps that is the more standard way of doing UI stuff?
And for (2), it would be dumb to sign it off for this page, and have it break some other page. So an idea of other affected pages would be nice.
Comment 5 Owen Leonard 2016-03-21 00:55:33 UTC
(In reply to M. Tompsett from comment #4)
> The questions in my mind before I decide what to sign off would be:
> 1) Are we going to have 'button' for sublists and 'a' for single action
> items? Should we even care?

I'm not trying to set a standard about what element should be used to make a button. The goal of using the Bootstrap framework CSS is to make the point moot, since <button> and <a> can be styled to look the same and behave the same. The goal of my alternative patch is to eliminate the necessity of using one element or the other because the styling looks off.

> And for (2), it would be dumb to sign it off for this page, and have it
> break some other page. So an idea of other affected pages would be nice.

My test plan lists pages which include elements representative of the kinds of things which might be affected by this change.
Comment 6 Marc Véron 2016-03-21 10:15:05 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2016-03-23 06:35:57 UTC
Hi Owen, followed your test plan and the 'Upload' button on the last step looks not quite right to me. The font is a bit bigger compared to other buttons and maybe a different one even? Can you check? It looked more in tune with the other buttons to me without the patch.
Comment 8 Owen Leonard 2016-03-23 12:26:26 UTC
(In reply to Katrin Fischer from comment #7)
> Hi Owen, followed your test plan and the 'Upload' button on the last step
> looks not quite right to me.

The upload button does look different with this patch, but now it looks like a submit button rather than a toolbar button. This makes it more consistent with other buttons which perform a similar action.
Comment 9 Katrin Fischer 2016-03-23 20:39:48 UTC
Created attachment 49459 [details] [review]
[PASSED QA] Bug 16100 [Alternate] Buttons in patron toolbar are styled differently

This patch makes modifications to the global CSS file in order to make
font rendering in buttons more consistent. The Bootstrap CSS is setting
font styles which are not being consistently overriden by the staff
client's CSS.

To test, apply the patch and clear your browser cache if necessary.
Check several places to confirm that the changes look correct and don't
go too far:

- Go to the "Patrons" home page. The "New patron" and "Patron lists"
  buttons should look consistent with each other.
- Locate a patron and view their detail page. Toolbar buttons should
  look correct.
- Go to Administration -> Libraries and Groups and click the "Delete"
  button on any library. Verify that the warning dialog buttons look
  correct.
- Go to Cataloging and open the advanced editor. Confirm that toolbar
  buttons look correct.
- Go to Tools -> Stage MARC records for import and confirm that the
  "Upload file" button looks consistent with other generic submit
  buttons.

Applied alternate patch only, followed test plan, buttons display as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Marc Véron 2016-03-24 15:28:27 UTC
*** Bug 16051 has been marked as a duplicate of this bug. ***
Comment 11 Brendan Gallagher 2016-03-24 17:17:46 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!