Bug 16438 - Use Font Awesome icons in batch templates
Summary: Use Font Awesome icons in batch templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Héctor Eduardo Castro Avalos
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16439 16456
  Show dependency treegraph
 
Reported: 2016-05-03 20:47 UTC by Héctor Eduardo Castro Avalos
Modified: 2016-12-05 21:27 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16438: Use Font Awesome icons in batch record deletion table (2.81 KB, patch)
2016-05-03 20:52 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16438: Use Font Awesome icons in batch templates (6.52 KB, patch)
2016-05-03 21:46 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16438: Use Font Awesome icons in batch templates (6.62 KB, patch)
2016-05-03 22:09 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 16438: (followup) change icons to one icon (3.42 KB, patch)
2016-05-04 16:47 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16438: (followup) change icons to one icon (3.41 KB, patch)
2016-05-04 16:52 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16438: (followup) remove item where no single icon exist for options (3.24 KB, patch)
2016-05-04 17:19 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16438: (followup) remove item where no single icon exist for options (3.34 KB, patch)
2016-05-04 17:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16438: Use Font Awesome icons in batch templates (6.68 KB, patch)
2016-05-04 18:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16438: (followup) remove item where no single icon exist for options (3.36 KB, patch)
2016-05-04 18:01 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Héctor Eduardo Castro Avalos 2016-05-03 20:47:35 UTC
Add Font Awesome icons in table for tables in authorities and bib records in batch record deletion
Comment 1 Héctor Eduardo Castro Avalos 2016-05-03 20:52:29 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-05-03 21:46:36 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2016-05-03 22:09:30 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2016-05-04 16:03:59 UTC
I would prefer that we use no icon if there is no single icon which works well.
Comment 5 Héctor Eduardo Castro Avalos 2016-05-04 16:47:58 UTC Comment hidden (obsolete)
Comment 6 Héctor Eduardo Castro Avalos 2016-05-04 16:52:43 UTC Comment hidden (obsolete)
Comment 7 Héctor Eduardo Castro Avalos 2016-05-04 16:55:16 UTC
Hi Owen and Jonathan

Please look if this is Ok

Regards
Comment 8 Owen Leonard 2016-05-04 17:04:27 UTC
My vote is still for no icon.
Comment 9 Héctor Eduardo Castro Avalos 2016-05-04 17:09:32 UTC
(In reply to Owen Leonard from comment #8)
> My vote is still for no icon.

For all options or just for those icons which don't work well?
Comment 10 Héctor Eduardo Castro Avalos 2016-05-04 17:19:51 UTC Comment hidden (obsolete)
Comment 11 Héctor Eduardo Castro Avalos 2016-05-04 17:22:55 UTC
Hi Owen

I've deleted the icons for options where icon doesn't fit well with description.

Feel free to change and/or close the bug if you think this isn't the right way. No biggie.

Regards
Comment 12 Owen Leonard 2016-05-04 17:33:16 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2016-05-04 18:00:57 UTC
Created attachment 51214 [details] [review]
Bug 16438: Use Font Awesome icons in batch templates

Add Font Awesome icons in tables in authorities and bib records
in batch item/record deletion, modification templates

To test:
1- Go to Tools > Batch item/record deletion/modification
2- Try to delete/modify itmes/bib and authorities records
3- Look all tables presented and notice about the new icons in Select all
   Clear all, etc.
4- Apply patch and repeat step 1 to 3

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work, nice view.
No Errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Jonathan Druart 2016-05-04 18:01:01 UTC
Created attachment 51215 [details] [review]
Bug 16438: (followup) remove item where no single icon exist for options

Remove the double icon in options where double icons don't work well

To test: follow the previous commit

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 15 Brendan Gallagher 2016-05-05 19:50:21 UTC
Pushed to Master - should be in the May 2016 Release.  thanks!