Bug 16439 - Allow styling to button for upload local cover images (Font Awesome Icons)
Summary: Allow styling to button for upload local cover images (Font Awesome Icons)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 16438
Blocks: 16456
  Show dependency treegraph
 
Reported: 2016-05-04 18:04 UTC by Héctor Eduardo Castro Avalos
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16439: Allow styling to button for upload local cover images (Font Awesome Icons) (1.78 KB, patch)
2016-05-04 18:08 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16439: Allow styling to button for upload local cover images (Font Awesome Icons) (1.94 KB, patch)
2016-05-05 14:18 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16439: Allow styling to button for upload local cover images (Font Awesome Icons) (2.00 KB, patch)
2016-05-05 19:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Héctor Eduardo Castro Avalos 2016-05-04 18:04:47 UTC
Improve button for upload local cover image with Font Awesome Icon
Comment 1 Héctor Eduardo Castro Avalos 2016-05-04 18:08:35 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-05-05 14:18:25 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-05-05 19:50:11 UTC
Created attachment 51256 [details] [review]
[PASSED QA] Bug 16439: Allow styling to button for upload local cover images (Font Awesome Icons)

Improve button for upload local cover image with Font Awesome Icon

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the button upload.
-Apply the patch and reload the page.
-The button is changed for class=btn btn-mini like the button "edit"
 used in items in the tab Holdings
-Also added the Font Awesome icon upload "fa fa-upload" class.

Button is styled as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-05-05 19:52:16 UTC
Pushed to Master - should be in the May 2016 Release.  thanks!
Comment 5 Julian Maurice 2016-05-16 12:25:42 UTC
Patch pushed to 3.22.x, will be in 3.22.7