Bug 16486 - Display the TIME a fine was collected/written off
Summary: Display the TIME a fine was collected/written off
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-10 11:28 UTC by Theodoros Theodoropoulos
Modified: 2017-06-13 16:34 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 16486: Display the timestamp for account payments/writeoffs (3.18 KB, patch)
2017-04-18 23:49 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16486: Display the timestamp for account payments/writeoffs (3.07 KB, patch)
2017-04-26 03:51 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED OFF] Bug 16486: Display the timestamp for account payments/writeoffs (3.14 KB, patch)
2017-05-02 21:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Theodoros Theodoropoulos 2016-05-10 11:28:07 UTC
In many cases it would be very useful to be able to know the time a fine was collected/written off (in addition to the date).

So ideally, the TIME could be shown next to the date in the Fines->Account tab.
(This would make sense in almost all cases except maybe in Accruing fines).

Alternatively, a text could be added to the description column. For example, "Payment, thanks" could become "Payment on 15/09/2015 14:30, thanks", "Writeoff" could become "Written off on 15/09/2015 14:30", etc
Comment 1 Aleisha Amohia 2017-04-18 23:49:03 UTC
Created attachment 62343 [details] [review]
Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT
Comment 2 Owen Leonard 2017-04-20 13:08:19 UTC
I like this change but shouldn't the date formatting be done in the template using '$KohaDates with_hours => 1' ?
Comment 3 Marc Véron 2017-04-21 07:33:52 UTC
(In reply to Owen Leonard from comment #2)
> I like this change but shouldn't the date formatting be done in the template
> using '$KohaDates with_hours => 1' ?

+1
Comment 4 Aleisha Amohia 2017-04-26 03:51:05 UTC
Created attachment 62703 [details] [review]
Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT
Comment 5 Katrin Fischer 2017-05-02 21:52:40 UTC
Created attachment 62995 [details] [review]
[SIGNED OFF] Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Theodoros Theodoropoulos 2017-05-03 06:49:52 UTC
Thank you all for your work on this request.
I can verify that the provided patch works as expected!
[FYI, for Koha 3.20 the patch needs one line less, because 'Hold waiting too long' is not available]

Having said that, unless you print slips with the text from the description, I think it would be more generic to simply change the date column to show hours/minutes in ALL fine lines.
Following Owen's suggestion, it would be something like this:

-  <td><span title="[% account.date %]">[% account.date |$KohaDates %]</span></td>
+  <td><span title="[% account.timestamp %]">[% account.timestamp |$KohaDates with_hours => 1 %]</span></td>

What do you think?
Comment 7 Jonathan Druart 2017-05-03 18:51:13 UTC
Would not it make sense to add it everywhere?

% git grep ', thanks' **/*.tt|cut -d':' -f1|uniq
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt

It seems that occurrences in pay.tt are not relevant, we do not display payments in this table.