Bug 18790 - Add ability to void payments
Summary: Add ability to void payments
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Whiteboard:
Keywords: Academy
Depends on: 18786
Blocks: 2696
  Show dependency treegraph
 
Reported: 2017-06-12 16:49 UTC by Kyle M Hall
Modified: 2017-11-15 19:52 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18790 - Add ability to void payments (7.39 KB, patch)
2017-06-12 16:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18790 - Add ability to void payments (7.33 KB, patch)
2017-08-03 14:07 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18790 - Add ability to void payments (7.44 KB, patch)
2017-08-11 22:12 UTC, ByWaterSandboxes
Details | Diff | Splinter Review
Bug 18790 - Add ability to void payments (7.51 KB, patch)
2017-09-29 15:30 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18790 - Add ability to void payments (7.45 KB, patch)
2017-11-15 14:16 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18790 [QA Followup] - Store the new offset for the void (658 bytes, patch)
2017-11-15 14:16 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18790 - Add ability to void payments (8.04 KB, patch)
2017-11-15 14:27 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2017-06-12 16:49:02 UTC
We've had the ability to 'reverse' a payment for a long time, but it would be much better if we had a true void payment function that replaces the paid amounts into the fee so that it appears as if the payment was never made.
Comment 1 Kyle M Hall 2017-06-12 16:54:01 UTC
Created attachment 64210 [details] [review]
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts
Comment 2 Shella 2017-06-22 06:42:47 UTC
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18790:
Cannot rebuild zebra: 
The command perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock fails with the following error: 'perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock' exited with value 2
The error message is: 
    Can't locate Koha/Account/Offsets.pm in @INC (you may need to install the Koha::Account::Offsets module) (@INC contains: /home/koha/src /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1 /usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at /home/koha/src/Koha/Account/Line.pm line 23.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account/Line.pm line 23.
Compilation failed in require at /home/koha/src/Koha/Account.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account.pm line 28.
Compilation failed in require at /home/koha/src/C4/Accounts.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Accounts.pm line 28.
Compilation failed in require at /home/koha/src/C4/Overdues.pm line 33.
BEGIN failed--compilation aborted at /home/koha/src/C4/Overdues.pm line 33.
Compilation failed in require at /home/koha/src/C4/Members.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/Members.pm line 30.
Compilation failed in require at /home/koha/src/C4/Reserves.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Reserves.pm line 28.
Compilation failed in require at /home/koha/src/C4/Circulation.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Circulation.pm line 28.
Compilation failed in require at /home/koha/src/C4/XSLT.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/XSLT.pm line 30.
Compilation failed in require at /home/koha/src/C4/Search.pm line 29.
BEGIN failed--compilation aborted at /home/koha/src/C4/Search.pm line 29.
Compilation failed in require at /home/koha/src/C4/AuthoritiesMarc.pm line 25.
BEGIN failed--compilation aborted at /home/koha/src/C4/AuthoritiesMarc.pm line 25.
Compilation failed in require at /home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26.
BEGIN failed--compilation aborted at /home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26. at /home/koha/lib/contrib/sandbox/cron/../Run.pm line 28.
Comment 3 Shella 2017-06-22 06:45:06 UTC
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18790:
Cannot rebuild zebra: 
The command perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock fails with the following error: 'perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock' exited with value 2
The error message is: 
    Can't locate Koha/Account/Offsets.pm in @INC (you may need to install the Koha::Account::Offsets module) (@INC contains: /home/koha/src /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1 /usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at /home/koha/src/Koha/Account/Line.pm line 23.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account/Line.pm line 23.
Compilation failed in require at /home/koha/src/Koha/Account.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account.pm line 28.
Compilation failed in require at /home/koha/src/C4/Accounts.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Accounts.pm line 28.
Compilation failed in require at /home/koha/src/C4/Overdues.pm line 33.
BEGIN failed--compilation aborted at /home/koha/src/C4/Overdues.pm line 33.
Compilation failed in require at /home/koha/src/C4/Members.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/Members.pm line 30.
Compilation failed in require at /home/koha/src/C4/Reserves.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Reserves.pm line 28.
Compilation failed in require at /home/koha/src/C4/Circulation.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Circulation.pm line 28.
Compilation failed in require at /home/koha/src/C4/XSLT.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/XSLT.pm line 30.
Compilation failed in require at /home/koha/src/C4/Search.pm line 29.
BEGIN failed--compilation aborted at /home/koha/src/C4/Search.pm line 29.
Compilation failed in require at /home/koha/src/C4/AuthoritiesMarc.pm line 25.
BEGIN failed--compilation aborted at /home/koha/src/C4/AuthoritiesMarc.pm line 25.
Compilation failed in require at /home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26.
BEGIN failed--compilation aborted at /home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26. at /home/koha/lib/contrib/sandbox/cron/../Run.pm line 28.
Comment 4 Kyle M Hall 2017-08-03 14:07:29 UTC
Created attachment 65468 [details] [review]
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts
Comment 5 ByWaterSandboxes 2017-08-11 22:12:18 UTC
Patch tested with a sandbox, by Koha-us conference <koha-us@koha-us.net>
Comment 6 ByWaterSandboxes 2017-08-11 22:12:35 UTC
Created attachment 65932 [details] [review]
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference <koha-us@koha-us.net>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>
Comment 7 Martha Fuerst 2017-08-28 15:11:14 UTC
Everything looks good - void doesn't show up on Account Offsets table, but fines restored successfully.
Comment 8 Kyle M Hall 2017-09-29 15:30:54 UTC
Created attachment 67478 [details] [review]
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference <koha-us@koha-us.net>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>
Comment 9 Kyle M Hall 2017-11-15 14:16:21 UTC
Created attachment 69158 [details] [review]
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference <koha-us@koha-us.net>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>
Comment 10 Kyle M Hall 2017-11-15 14:16:30 UTC
Created attachment 69159 [details] [review]
Bug 18790 [QA Followup] - Store the new offset for the void
Comment 11 Kyle M Hall 2017-11-15 14:27:00 UTC
Created attachment 69161 [details] [review]
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference <koha-us@koha-us.net>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>
Comment 12 Katrin Fischer 2017-11-15 19:52:34 UTC
Should we consider logging reversing or voiding payments somewhere? We have talked to libraries that have to report regularly on money collected and changing payments later on could cause confusing results if not used very carefully.