Letters.pm reformats the time once for title, once for content, this causes improper formatting of timestamps and makes all times appear as AM
Created attachment 51934 [details] [review] Bug 16624 - Times are formatted incorrectly in slips ( AM PM ) due to double processing To test: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct
Created attachment 51937 [details] [review] [SIGNED-OFF] Bug 16624 - Times are formatted incorrectly in slips ( AM PM ) due to double processing To test: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct Signed-off-by: Jason Burds <JBurds@dubuque.lib.ia.us>
Created attachment 52121 [details] [review] Bug 16624: Add regression tests
Created attachment 52122 [details] [review] Bug 16624: Fix regression displaying a letter with hours Bug 13622 has introduced a bug, if pref TimeFormat is 12hr and a date is displayed in both title and content of the letter. Test plan: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct
Nick, Looking at the tests, your patch is wrong. Have a look at this counter-patch. Note that we will need bug 16441 to fix the problem in the existing tests (see second patch of bug 16441).
Created attachment 52126 [details] [review] Bug 16624: Add regression tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 52127 [details] [review] Bug 16624: Fix regression displaying a letter with hours Bug 13622 has introduced a bug, if pref TimeFormat is 12hr and a date is displayed in both title and content of the letter. Test plan: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 52453 [details] Screenshot of patron page being affected A note on this particular bug: I don't think it just affects the slips. It seems to affect the actual due date in Koha. When we check out an item and set the due date manually to the end of the day, it instantly becomes overdue. It also displays on the screen as being due in the morning. I am not sure if this bug-fix addresses this particular issue or no. It might need to be its own bug.
(In reply to Karl Holten from comment #8) > Created attachment 52453 [details] > Screenshot of patron page being affected > > A note on this particular bug: I don't think it just affects the slips. It > seems to affect the actual due date in Koha. > > When we check out an item and set the due date manually to the end of the > day, it instantly becomes overdue. It also displays on the screen as being > due in the morning. I am not sure if this bug-fix addresses this particular > issue or no. It might need to be its own bug. It's not related, please open a new bug report (and link it to this one using "see also")
I can reproduce the problem for the slip printing, but not for the checkouts table. The latter displays correctly for me.
Created attachment 52546 [details] [review] [PASSED QA] Bug 16624: Add regression tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 52547 [details] [review] [PASSED QA] Bug 16624: Fix regression displaying a letter with hours Bug 13622 has introduced a bug, if pref TimeFormat is 12hr and a date is displayed in both title and content of the letter. Test plan: 1 - Checkout an item (with default time 11:59:00 PM) 2 - Generate a quickslip 3 - Notice the time is 'AM' 4 - Apply patch 5 - Generate quickslip 6 - Note time is correct Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Jonathan Druart from comment #9) > (In reply to Karl Holten from comment #8) > > Created attachment 52453 [details] > > Screenshot of patron page being affected > > > > A note on this particular bug: I don't think it just affects the slips. It > > seems to affect the actual due date in Koha. > > > > When we check out an item and set the due date manually to the end of the > > day, it instantly becomes overdue. It also displays on the screen as being > > due in the morning. I am not sure if this bug-fix addresses this particular > > issue or no. It might need to be its own bug. > > It's not related, please open a new bug report (and link it to this one > using "see also") See Bug 16780
Pushed to master for Koha 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.02.
Patches pushed to 3.22.x, will be in 3.22.10