To recreate: 1 - On the checkout screen for a patron specify a due date and a PM time 2 - Checkout an item 3 - Note the due date for the item and the time in the box have switched to AM
Nick, I confirm the issue. This is a tricky one, it's because the AM/PM breaks the parsing of the dates somewhere. Do you know if it's a regression from a previous stable version or if it has never worked?
It's a regression, it used to work for our institutions before our update to 3.22.
Comes from 165 $duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso' }); } 166 if ( $duedatespec ); Introduced by commit 421fae24f1cdcbe0ccc18de784454d0ca07ebe90 Bug 14903: Remove C4::Dates from circ/circulation.pl (and more)
Created attachment 52781 [details] [review] Bug 16780 - Specify due date always sets time as AM when using 12 hour time format This regression is occurs because the time format for the checkout date/time widget is only meant to be given in 24 hour format. The time due should not be converted to 12 hr time even if the library has 12 hour set as their preferred time format. Test Plan: 1) Performat a backdated checkout with a date due that has a PM time 2) Note the date/time picker on the confirmition screen shows the time in AM/PM 2) Note the time is not stored correctly 3) Apply this patch 4) Repeate step 1 5) Note the confirmation date/time picker now show the time in 24hr format 6) Note the time was stored correctly
Smart fix, I did not think about that! Will QA it as soon as it's signed off.
Created attachment 52884 [details] [review] Bug 16780 - Specify due date always sets time as AM when using 12 hour time format This regression is occurs because the time format for the checkout date/time widget is only meant to be given in 24 hour format. The time due should not be converted to 12 hr time even if the library has 12 hour set as their preferred time format. Test Plan: 1) Performat a backdated checkout with a date due that has a PM time 2) Note the date/time picker on the confirmition screen shows the time in AM/PM 2) Note the time is not stored correctly 3) Apply this patch 4) Repeate step 1 5) Note the confirmation date/time picker now show the time in 24hr format 6) Note the time was stored correctly Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>
Created attachment 52896 [details] [review] Bug 16780 - Specify due date always sets time as AM when using 12 hour time format This regression is occurs because the time format for the checkout date/time widget is only meant to be given in 24 hour format. The time due should not be converted to 12 hr time even if the library has 12 hour set as their preferred time format. Test Plan: 1) Performat a backdated checkout with a date due that has a PM time 2) Note the date/time picker on the confirmition screen shows the time in AM/PM 2) Note the time is not stored correctly 3) Apply this patch 4) Repeate step 1 5) Note the confirmation date/time picker now show the time in 24hr format 6) Note the time was stored correctly Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11!
Can we have this backported to 3.22? One of our branches has hourly equipment and it impacts a great portion of their checkout transactions.
Pushed in 16.05. Will be in 16.05.02.
Patch pushed to 3.22.x, will be in 3.22.10