Bug 16643 - Make debian/list-deps aware of Jessie folder structure
Summary: Make debian/list-deps aware of Jessie folder structure
Status: RESOLVED DUPLICATE of bug 17043
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Mirko Tietgen
QA Contact: Testopia
URL:
Keywords:
Depends on: 17043
Blocks:
  Show dependency tree / graph
 
Reported: 2016-06-03 08:47 UTC by Mirko Tietgen
Modified: 2018-05-30 10:29 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16643 - Make debian/list-deps aware of Jessie folder structure (1.12 KB, patch)
2016-06-04 07:45 UTC, Mirko Tietgen 		Details | Diff | Splinter Review
Bug 16643 - Make debian/list-deps aware of Jessie folder structure (1.23 KB, patch)
2016-08-09 15:56 UTC, Mirko Tietgen 		Details | Diff | Splinter Review
Bug 16643 - Make debian/list-deps aware of Jessie folder structure (1.24 KB, patch)
2016-08-09 16:09 UTC, Mirko Tietgen 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mirko Tietgen 2016-06-03 08:47:18 UTC 
debian/list-deps does not work on Jessie because the folder structure has changed.
Comment 1 Mirko Tietgen 2016-06-04 07:45:57 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2016-08-09 15:56:24 UTC Comment hidden (obsolete)
Comment 3 Mirko Tietgen 2016-08-09 16:03:12 UTC 
You can test in a regex tester if the shorter regex matches the four examples from the patch. https://regex101.com

/usr/lib/x86_64-linux-gnu/perl/5.20.2/POSIX.pm
/usr/lib/perl/5.14.2/POSIX.pm
/usr/lib/perl5/POSIX.pm
/usr/lib/x86_64-linux-gnu/perl5/5.20/YAML/Syck.pm
Comment 4 Mirko Tietgen 2016-08-09 16:09:25 UTC 
Created attachment 54226 [details] [review]
Bug 16643 - Make debian/list-deps aware of Jessie folder structure

the old regex did not match the new folder structure

Rebased to depend on bug 17043
Comment 5 Mark Tompsett 2016-12-30 19:34:02 UTC 
^/usr/((lib|share)/perl5|
       (lib|share)/perl/[0-9.]+|
       (lib|share)/.*-linux-gnu.*/perl/[0-9.]+|
       (lib|share)/.*-linux-gnu.*/perl5/[0-9.]+)

^/usr/((lib|share)/(.*-linux-gnu.*/)?perl5?/?[0-9.]+)?

Ah.... there is the difference, the first one is lacking the "/[0-9.]+" part. The four examples you gave do match.

/usr/lib/perl5/5.14.2/POSIX.pm -- would not match the first. But is that even possible.
Comment 6 Katrin Fischer 2017-10-15 10:42:00 UTC 
Mark, did you intend to sign off or is there an open question?

I am getting a bit lost here, but would be nice to see this moving along finally. When I try to use ./debian/list-deps I get a lot of output with "EEK" that seems the same with and without the patch. Need some hints to do better testing.
Comment 7 Mark Tompsett 2017-10-15 23:24:56 UTC 
(In reply to Katrin Fischer from comment #6)
> Mark, did you intend to sign off or is there an open question?

It's been a while, but that seems to be more of a "something's not quite right some how".
Comment 8 Mark Tompsett 2017-10-16 02:27:06 UTC 
(In reply to Mirko Tietgen from comment #0)
> debian/list-deps does not work on Jessie because the folder structure has
> changed.

Please give a sample path that fails. Because while your regular expression tweak is prettier and a little broader, I can't think of a case that we might actually care about that would fail. Changing to in discussion as a result.
Comment 9 Mirko Tietgen 2018-05-30 10:29:38 UTC 

*** This bug has been marked as a duplicate of bug 17043 ***