In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems with following, errorprone monster: %s %s at%sfor delivery at %s %s %s since %s %s %s (placed %s) %s %s %s [%% UNLESS ( item.itemnotforloan or item.notforloan_per_itemtype or item.onloan or item.itemlost or item.withdrawn or item.damaged or item.transfertwhen or item.reservedate ) %%] Available %s %s
Created attachment 53184 [details] [review] Bug 16871 - Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po)
Created attachment 53477 [details] [review] [SIGNED-OFF]Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
1/ Looking at the logic it seems that reservedate could be missing (?) 2/ Before the patch the string was "waiting at LIBRARY since DATE", now it's "waiting since DATE at LIBRARY". I don't think it represents a big change but I would prefer to get the opinion of English native speakers.
(In reply to Jonathan Druart from comment #3) > 1/ Looking at the logic it seems that reservedate could be missing (?) (...) We had two conditions [% IF ( item.waitingdate ) %] at the same level (line 693ff and 707ff before patch). I merged them (line 693ff with patch), including reservedate. > 2/ Before the patch the string was "waiting at LIBRARY since DATE", now it's > "waiting since DATE at LIBRARY". I don't think it represents a big change > but I would prefer to get the opinion of English native speakers. I will ask on IRC.
Responding from IRC conversation: You would want to use "waiting at LIBRARY since DATE". The other sentence structure doesn't sound right.
Created attachment 53719 [details] [review] Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Amended for wording (comment #5) 2016-07-26 mv
Created attachment 53838 [details] [review] Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Amended for wording (comment #5) 2016-07-26 mv
It's ok for me. I let the RM takes care of the wording.
Wording is good for me... Pushed to master. Should be in the November 2016 release. Thanks!
Pushed in 16.05. Will be in 16.05.03.
Patch pushed to 3.22.x, will be in 3.22.10