Some libraries would like to be able to restore items accidentally deleted. This should be possible, rows can be copied over as long as there are checks in place for unique ids.
This is a great idea.
Agreed! I've heard interest in this feature from other libraries.
I have written this code already and would like to add the feature.
(In reply to davewood from comment #3) > I have written this code already and would like to add the feature. If you haven't already, take a look at the following: https://koha-community.org/get-involved/for-developers/ If you need help attaching patches, I'd suggest hopping on IRC or the Koha Developers List: https://koha-community.org/support/
We'd be also interested in this. Items seem a little less complicated, maybe they would make a good starting point.
*** Bug 13556 has been marked as a duplicate of this bug. ***
Yes, this should be a core feature! Maybe the InLibro Plugin is a good start ? https://github.com/inLibro/koha-plugin-undelete-records
(In reply to Michaela Sieber from comment #7) > Yes, this should be a core feature! > > Maybe the InLibro Plugin is a good start ? > > https://github.com/inLibro/koha-plugin-undelete-records I ended up using this as inspiration for a pure SQL undelete for 1 bib record (and attached items) I needed to undelete. I should look at biblio_metadata again, as it seems that the ID wasn't able to be restored. Had to use a new ID... which is reminiscent of that autoincrement bug. Hmm... it was an old database. (I noticed the InLibro code also gets a new ID for restoring biblio_metadata, so must be a more common issue?)
Of course, "undelete" only works for the bib record and items themselves. Other tables using foreign keys will have cascading deletes. So the data in the "linktracker" table for instance cannot be restored. It's permanently deleted. Given how many people seem to accidentally delete things... I reckon that soft delete feature would be handy. (Of course, it would be a mountain of work to refactor Koha to handle soft deletes...)
Plug-in for InLibro also doesn't work for 24.05. :( We are still getting a lot of request about this from libraries.
Some sort of undelete function would be great. However, I can just pull the record from an old backup of our catalog. Thankfully I've not needed to do this very often.
Created attachment 188670 [details] [review] Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home
Created attachment 188671 [details] [review] Bug 17387: add deleted items restore api
Created attachment 188672 [details] [review] Bug 17387: add deleted biblios restore api
Created attachment 188673 [details] [review] Bug 17387: update swagger for deleted biblios/items restore
Created attachment 188674 [details] [review] Bug 17387: add restore item/biblio tests
Created attachment 188675 [details] [review] Bug 17387: reindex biblio/item on restore
Created attachment 188676 [details] [review] Bug 17387: item cannot be restored if associated biblio does not exist
Created attachment 188677 [details] [review] Bug 17387: add restore records page
Created attachment 188678 [details] [review] Bug 17387: add pagination headers and support comma-delimited Accept headers
Created attachment 188679 [details] [review] Bug 17387: add biblio embed to deleteditems return
Created attachment 188680 [details] [review] Bug 17387: add modal warning for items with deleted biblios
Created attachment 188681 [details] [review] Bug 17387: add items embed to deleted biblios API
Created attachment 188682 [details] [review] Bug 17387: add modal for restoring biblios with item selection
Created attachment 188683 [details] [review] Bug 17387: add sidebar date filtering for item/biblio restore
Created attachment 188684 [details] [review] Bug 17387: add links for restore item/biblio to cataloguing
Created attachment 188685 [details] [review] Bug 17387: add restore records permission as child of cataloguing perms
Created attachment 188686 [details] [review] Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home
Created attachment 188687 [details] [review] Bug 17387: add deleted items restore api
Created attachment 188688 [details] [review] Bug 17387: add deleted biblios restore api
Created attachment 188689 [details] [review] Bug 17387: update swagger for deleted biblios/items restore
Created attachment 188690 [details] [review] Bug 17387: add restore item/biblio tests
Created attachment 188691 [details] [review] Bug 17387: reindex biblio/item on restore
Created attachment 188692 [details] [review] Bug 17387: item cannot be restored if associated biblio does not exist
Created attachment 188693 [details] [review] Bug 17387: add restore records page
Created attachment 188694 [details] [review] Bug 17387: add pagination headers and support comma-delimited Accept headers
Created attachment 188695 [details] [review] Bug 17387: add biblio embed to deleteditems return
Created attachment 188696 [details] [review] Bug 17387: add modal warning for items with deleted biblios
Created attachment 188697 [details] [review] Bug 17387: add items embed to deleted biblios API
Created attachment 188698 [details] [review] Bug 17387: add modal for restoring biblios with item selection
Created attachment 188699 [details] [review] Bug 17387: add sidebar date filtering for item/biblio restore
Created attachment 188700 [details] [review] Bug 17387: add links for restore item/biblio to cataloguing
Created attachment 188701 [details] [review] Bug 17387: add restore records permission as child of cataloguing perms
Promising! Thx
Created attachment 188780 [details] [review] Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188781 [details] [review] Bug 17387: add deleted items restore api Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188782 [details] [review] Bug 17387: add deleted biblios restore api Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188783 [details] [review] Bug 17387: update swagger for deleted biblios/items restore Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188784 [details] [review] Bug 17387: add restore item/biblio tests Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188785 [details] [review] Bug 17387: reindex biblio/item on restore Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188786 [details] [review] Bug 17387: item cannot be restored if associated biblio does not exist Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188787 [details] [review] Bug 17387: add restore records page Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188788 [details] [review] Bug 17387: add pagination headers and support comma-delimited Accept headers Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188789 [details] [review] Bug 17387: add biblio embed to deleteditems return Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188790 [details] [review] Bug 17387: add modal warning for items with deleted biblios Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188791 [details] [review] Bug 17387: add items embed to deleted biblios API Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188792 [details] [review] Bug 17387: add modal for restoring biblios with item selection Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188793 [details] [review] Bug 17387: add sidebar date filtering for item/biblio restore Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188794 [details] [review] Bug 17387: add links for restore item/biblio to cataloguing Signed-off-by: Michaela <michaela.sieber@kit.edu>
Created attachment 188795 [details] [review] Bug 17387: add restore records permission as child of cataloguing perms Signed-off-by: Michaela <michaela.sieber@kit.edu>
Hi Jacob, I've tested everythink and it worked as expected, thats why I sign off. BUT : what I really miss is the logging about the undelete action. The deletions are logged in the action logs and if we now do an undelete this should be logged as well. I think this is not to hard to implement but I recommend it very much! Unfortunately there seems to be a Bug in Main with the cataloguing permissions. Even if my user has the whole module permission (editcatalogue) including various batch options I only see the fast cataloging Button as option, means I also could not use the Button on the catloguing home page for tests with my restricted user. so I tested just via URL .../restore-records.pl Maybe interesting for other testers...
Echoing Michaela, the action logs really shoud record the un-delete.
(In reply to Michaela Sieber from comment #61) > Unfortunately there seems to be a Bug in Main with the cataloguing > permissions. Even if my user has the whole module permission > (editcatalogue) including various batch options I only see the fast > cataloging Button as option, means I also could not use the Button on the > catloguing home page for tests with my restricted user. I've filed Bug 41160 for this.
(In reply to Andrew Fuerste-Henry from comment #63) > (In reply to Michaela Sieber from comment #61) > > Unfortunately there seems to be a Bug in Main with the cataloguing > > permissions. Even if my user has the whole module permission > > (editcatalogue) including various batch options I only see the fast > > cataloging Button as option, means I also could not use the Button on the > > catloguing home page for tests with my restricted user. > > I've filed Bug 41160 for this. Hmm, Lucas has wisely pointed on that all of the other buttons on the cataloging home page and tied to Tools permissions. Which makes sense because they were previously all on the Tools page. Updating my bug, but also wanted to mention it here.
I completely agree, we should track this in the action_logs. I will get this added as a follow up shortly. Didn't even cross my mind! In terms of the permissions issues, would you prefer I change the permissions to match the other tools on the cataloguing page in the interim for consistency?
(In reply to Jacob O'Mara from comment #65) > I completely agree, we should track this in the action_logs. I will get this > added as a follow up shortly. Didn't even cross my mind! > > In terms of the permissions issues, would you prefer I change the > permissions to match the other tools on the cataloguing page in the interim > for consistency? Yes, I think it makes sense to put this permission under Tools with the other cataloging tools for now. Thanks!
Thank You! And yes, I think it would be better to have the new permission in the tools section as well as all the other batch tools. The more I think about it I don't think it will be an interim solution ;-) It makes sense that batch tools are not part of the cataloguing permissions. These are powerful tools for advanced users, I don't think we can "just migrate" them into the existing module permission
Created attachment 189046 [details] [review] Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home
Created attachment 189047 [details] [review] Bug 17387: add deleted items restore api
Created attachment 189048 [details] [review] Bug 17387: add deleted biblios restore api
Created attachment 189049 [details] [review] Bug 17387: update swagger for deleted biblios/items restore
Created attachment 189050 [details] [review] Bug 17387: add restore item/biblio tests
Created attachment 189051 [details] [review] Bug 17387: reindex biblio/item on restore
Created attachment 189052 [details] [review] Bug 17387: item cannot be restored if associated biblio does not exist
Created attachment 189053 [details] [review] Bug 17387: add restore records page
Created attachment 189054 [details] [review] Bug 17387: add pagination headers and support comma-delimited Accept headers
Created attachment 189055 [details] [review] Bug 17387: add biblio embed to deleteditems return
Created attachment 189056 [details] [review] Bug 17387: add modal warning for items with deleted biblios
Created attachment 189057 [details] [review] Bug 17387: add items embed to deleted biblios API
Created attachment 189058 [details] [review] Bug 17387: add modal for restoring biblios with item selection
Created attachment 189059 [details] [review] Bug 17387: add sidebar date filtering for item/biblio restore
Created attachment 189060 [details] [review] Bug 17387: add links for restore item/biblio to cataloguing
Created attachment 189061 [details] [review] Bug 17387: add restore records permission as child of cataloguing perms
Created attachment 189062 [details] [review] Bug 17387: add logging for biblio/item restore This adds RESTORE action for biblios and items to the action log
Done and done! Thanks for the input, both.
With apologies for throwing a wrench into thing: This needs to respect limits to item editing based on library groups. As is, this allows a user to restore items from other library groups that they would not be able to modify or delete. To recreate with KTD data: - Create a library group with "Limit item editing by group" selected - Add Centerville to your group - Grant permissions to Midway patron Henry Acevedo: catalogue, edit_catalogue, edit_items, items_batchdel, items_batchmod, records_restore - Log in as Henry, go to biblio 344 (E street shuffle), which contains a mix of Centerville and Midway items - Confirm you cannot edit or delete the Centerville items from the bib record - Confirm you cannot edit or delete the Centerville items from the batch item tools - Log in as a superlibrarian - Delete biblio 344 and all attached items - Log in as Henry - Confirm you can restore biblio 344 and all attached items With that Groups setup and those permissions, Henry should be allowed to restore the biblio and the Midway item, but not the Centerville items
Created attachment 189082 [details] [review] Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home
Created attachment 189083 [details] [review] Bug 17387: add deleted items restore api
Created attachment 189084 [details] [review] Bug 17387: add deleted biblios restore api
Created attachment 189085 [details] [review] Bug 17387: update swagger for deleted biblios/items restore
Created attachment 189086 [details] [review] Bug 17387: add restore item/biblio tests
Created attachment 189087 [details] [review] Bug 17387: reindex biblio/item on restore
Created attachment 189088 [details] [review] Bug 17387: item cannot be restored if associated biblio does not exist
Created attachment 189089 [details] [review] Bug 17387: add restore records page
Created attachment 189090 [details] [review] Bug 17387: add pagination headers and support comma-delimited Accept headers
Created attachment 189091 [details] [review] Bug 17387: add biblio embed to deleteditems return
Created attachment 189092 [details] [review] Bug 17387: add modal warning for items with deleted biblios
Created attachment 189093 [details] [review] Bug 17387: add items embed to deleted biblios API
Created attachment 189094 [details] [review] Bug 17387: add modal for restoring biblios with item selection
Created attachment 189095 [details] [review] Bug 17387: add sidebar date filtering for item/biblio restore
Created attachment 189096 [details] [review] Bug 17387: add links for restore item/biblio to cataloguing
Created attachment 189097 [details] [review] Bug 17387: add restore records permission as child of cataloguing perms
Created attachment 189098 [details] [review] Bug 17387: add logging for biblio/item restore This adds RESTORE action for biblios and items to the action log
Created attachment 189099 [details] [review] Bug 17387: (follow-up) take library groups in to account for permissions check
Created attachment 189100 [details] [review] Bug 17387: (follow-up) restore tests should account for new library groups checks
Good spot. Follow up added and moved back to Signed off/Needs QA. Thanks for taking a look so quickly!
This is going to break xt/api.t tests: xt/api.t ........................................ 1/8 # Failed test at xt/api.t line 93. # got: '2' # expected: '0' # $VAR1 = [ # { # 'name' => 'body', # 'route' => '/deleted/biblios/{biblio_id}', # 'type' => 'parameter', # 'verb' => 'put' # }, # { # 'verb' => 'put', # 'type' => 'response', # 'name' => '200', # 'route' => '/deleted/biblios/{biblio_id}' # } # ];
Created attachment 189101 [details] [review] Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home
Created attachment 189102 [details] [review] Bug 17387: add deleted items restore api
Created attachment 189103 [details] [review] Bug 17387: add deleted biblios restore api
Created attachment 189104 [details] [review] Bug 17387: update swagger for deleted biblios/items restore
Created attachment 189105 [details] [review] Bug 17387: add restore item/biblio tests
Created attachment 189106 [details] [review] Bug 17387: reindex biblio/item on restore
Created attachment 189107 [details] [review] Bug 17387: item cannot be restored if associated biblio does not exist
Created attachment 189108 [details] [review] Bug 17387: add restore records page
Created attachment 189109 [details] [review] Bug 17387: add pagination headers and support comma-delimited Accept headers
Created attachment 189110 [details] [review] Bug 17387: add biblio embed to deleteditems return
Created attachment 189111 [details] [review] Bug 17387: add modal warning for items with deleted biblios
Created attachment 189112 [details] [review] Bug 17387: add items embed to deleted biblios API
Created attachment 189113 [details] [review] Bug 17387: add modal for restoring biblios with item selection
Created attachment 189114 [details] [review] Bug 17387: add sidebar date filtering for item/biblio restore
Created attachment 189115 [details] [review] Bug 17387: add links for restore item/biblio to cataloguing
Created attachment 189116 [details] [review] Bug 17387: add restore records permission as child of cataloguing perms
Created attachment 189117 [details] [review] Bug 17387: add logging for biblio/item restore This adds RESTORE action for biblios and items to the action log
Created attachment 189118 [details] [review] Bug 17387: (follow-up) take library groups in to account for permissions check
Created attachment 189119 [details] [review] Bug 17387: (follow-up) restore tests should account for new library groups checks
Question about child records / component parts. Is there a way to identify if the bibliographic record had child records / component parts that also needs to be restored? The linkage between monographic record and component record is in the component records field 773 (in MARC21). Or do the restorer just have to know that there are child records too? I did not see any indication that listed record is a child record or that monographic record has child records.
(In reply to Anneli Österman from comment #127) > Question about child records / component parts. Is there a way to identify > if the bibliographic record had child records / component parts that also > needs to be restored? The linkage between monographic record and component > record is in the component records field 773 (in MARC21). Or do the restorer > just have to know that there are child records too? I did not see any > indication that listed record is a child record or that monographic record > has child records. I don't think we took that into account right now and I think it should be treated as it's own development on top of this. Could you submit a new bug depending on this one with your needs and requirements Anneli?
Thank you Martin for your answer. I added a new bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41295 about the component parts.