It would be nice to have permission just for reverse payments
With bug 20629 the option to reverse payments will be gone. I am changing this to be a permission for the replacement: voiding payments.
Created attachment 169109 [details] [review] Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone
Created attachment 169310 [details] [review] Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone
There is error during updatedatabase: ERROR - {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 739. at /kohadevbox/koha/C4/Installer.pm line 741
Created attachment 169384 [details] [review] Bug 17473: (follow-up) add semicolon after use Modern::Perl
Created attachment 169386 [details] [review] Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 169387 [details] [review] Bug 17473: (follow-up) add semicolon after use Modern::Perl Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>