Bug 17595 - Add button for creating manual invoice (aka fine or fee) to patron toolbar
Summary: Add button for creating manual invoice (aka fine or fee) to patron toolbar
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 17596
  Show dependency treegraph
 
Reported: 2016-11-09 13:31 UTC by Josef Moravec
Modified: 2020-01-03 23:06 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17595: Add buttonu for creating fine to patron toolbar (1.44 KB, patch)
2016-11-09 13:55 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 17595: Add buttonu for creating fine to patron toolbar (1.50 KB, patch)
2016-11-30 00:01 UTC, Mika
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2016-11-09 13:31:59 UTC

    
Comment 1 Josef Moravec 2016-11-09 13:55:21 UTC Comment hidden (obsolete)
Comment 2 Mika 2016-11-30 00:01:55 UTC
Created attachment 57813 [details] [review]
Bug 17595: Add buttonu for creating fine to patron toolbar

Test plan:
0) Apply the patch
1) Go to one of patron pages (circulation, moremember, ...)
2) Note the new "Create fine" button
3) Try add the fine through this button
4) Go through all patron pages and confirm, the button is visible on
every page that uses this toolbar

Signed-off-by: Mika Smith <mikasmith@catalyst.net.nz>
Comment 3 Jonathan Druart 2016-11-30 09:54:03 UTC
I am not sure that makes sense to have this new button in the toolbar. We already have a link to "Fines" in the left menu.
Or in "More"?

Moreover you should check if the logged in librarian has the borrowers permissions to display this button (CAN_user_borrowers)

Ccing Owen to get his opinion.
Comment 4 Josef Moravec 2016-11-30 10:25:22 UTC
(In reply to Jonathan Druart from comment #3)
> I am not sure that makes sense to have this new button in the toolbar. We
> already have a link to "Fines" in the left menu.
> Or in "More"?

The experience from our library says the we absolutely need this - fines management is last bottleneck in our circulation proccess.
Yes, it can maybe live in "More", but I wanted to make this button split button, with posible values... so it would end with 2 clicks and 1 page reload less for inserting a fine manually...

But we never needed the button "Duplicate" on patron toolbar...

The best way could be to make the toolbars configurable, similar to table columns?

> Moreover you should check if the logged in librarian has the borrowers
> permissions to display this button (CAN_user_borrowers)

You are right, I'll 

> Ccing Owen to get his opinion.

Good idea ;)
Comment 5 Owen Leonard 2018-05-31 16:04:39 UTC
I could see the "Fines" button being a dropdown with "Pay fines," "Create manual invoice," and "Create manual credit." What would you have as the default action for a split button?

Whether or not "Create fine" becomes a button, menu, or "More" menu item I suggest that we also make "Edit" into a split button with "Duplicate" and "Add child" as the secondary actions.