Created attachment 57389 [details] [review] Bug 17595: Add buttonu for creating fine to patron toolbar Test plan: 0) Apply the patch 1) Go to one of patron pages (circulation, moremember, ...) 2) Note the new "Create fine" button 3) Try add the fine through this button 4) Go through all patron pages and confirm, the button is visible on every page that uses this toolbar
Created attachment 57813 [details] [review] Bug 17595: Add buttonu for creating fine to patron toolbar Test plan: 0) Apply the patch 1) Go to one of patron pages (circulation, moremember, ...) 2) Note the new "Create fine" button 3) Try add the fine through this button 4) Go through all patron pages and confirm, the button is visible on every page that uses this toolbar Signed-off-by: Mika Smith <mikasmith@catalyst.net.nz>
I am not sure that makes sense to have this new button in the toolbar. We already have a link to "Fines" in the left menu. Or in "More"? Moreover you should check if the logged in librarian has the borrowers permissions to display this button (CAN_user_borrowers) Ccing Owen to get his opinion.
(In reply to Jonathan Druart from comment #3) > I am not sure that makes sense to have this new button in the toolbar. We > already have a link to "Fines" in the left menu. > Or in "More"? The experience from our library says the we absolutely need this - fines management is last bottleneck in our circulation proccess. Yes, it can maybe live in "More", but I wanted to make this button split button, with posible values... so it would end with 2 clicks and 1 page reload less for inserting a fine manually... But we never needed the button "Duplicate" on patron toolbar... The best way could be to make the toolbars configurable, similar to table columns? > Moreover you should check if the logged in librarian has the borrowers > permissions to display this button (CAN_user_borrowers) You are right, I'll > Ccing Owen to get his opinion. Good idea ;)
I could see the "Fines" button being a dropdown with "Pay fines," "Create manual invoice," and "Create manual credit." What would you have as the default action for a split button? Whether or not "Create fine" becomes a button, menu, or "More" menu item I suggest that we also make "Edit" into a split button with "Duplicate" and "Add child" as the secondary actions.