Bug 18041 - Updating buttons in Batch Item Mod and Deletion
Summary: Updating buttons in Batch Item Mod and Deletion
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 17873
  Show dependency treegraph
 
Reported: 2017-02-02 23:08 UTC by Aleisha Amohia
Modified: 2023-09-10 11:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18041: Updating buttons in Batch Item modification and deletion (3.73 KB, patch)
2017-02-02 23:23 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18041: Updating buttons in Batch Item modification and deletion (3.81 KB, patch)
2017-02-06 22:45 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18041: Updating buttons in Batch Item modification and deletion (3.98 KB, patch)
2017-02-10 14:45 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2017-02-02 23:08:49 UTC
The buttons in the whole process are styled differently for both modification and deletion. They should use bootstrap 3 styling
Comment 1 Aleisha Amohia 2017-02-02 23:23:32 UTC
Created attachment 59834 [details] [review]
Bug 18041: Updating buttons in Batch Item modification and deletion

To test:
1) Go to Tools -> Batch item modification
2) Put a barcode in and click Continue (notice ugly button)
3) Scroll to the bottom of the page and click Save (you don't have to
    make any changes) (Notice ugly button)
4) I am leaving the Return button as is
5) Go to Tools -> Batch item deletion
6) Put a barcode in and click Continue (notice ugly button)
7) Uncheck the selected item (so you don't actually delete anything) and
click Delete selected items (Notice ugly button)
8) I am leaving the Return button as is
9) Apply patch and repeat steps 1-8. Notice changes to buttons

Sponsored-by: Catalyst IT
Comment 2 Josef Moravec 2017-02-03 09:34:11 UTC
The same as comment 2 on bug 18042
Comment 3 Aleisha Amohia 2017-02-06 22:45:34 UTC
Created attachment 59958 [details] [review]
Bug 18041: Updating buttons in Batch Item modification and deletion

To test:
1) Go to Tools -> Batch item modification
2) Put a barcode in and click Continue (notice ugly button)
3) Scroll to the bottom of the page and click Save (you don't have to
    make any changes) (Notice ugly button)
4) I am leaving the Return button as is
5) Go to Tools -> Batch item deletion
6) Put a barcode in and click Continue (notice ugly button)
7) Uncheck the selected item (so you don't actually delete anything) and
click Delete selected items (Notice ugly button)
8) I am leaving the Return button as is
9) Apply patch and repeat steps 1-8. Notice changes to buttons

Sponsored-by: Catalyst IT
Comment 4 Marc Véron 2017-02-10 14:45:21 UTC
Created attachment 60118 [details] [review]
Bug 18041: Updating buttons in Batch Item modification and deletion

To test:
1) Go to Tools -> Batch item modification
2) Put a barcode in and click Continue (notice ugly button)
3) Scroll to the bottom of the page and click Save (you don't have to
    make any changes) (Notice ugly button)
4) I am leaving the Return button as is
5) Go to Tools -> Batch item deletion
6) Put a barcode in and click Continue (notice ugly button)
7) Uncheck the selected item (so you don't actually delete anything) and
click Delete selected items (Notice ugly button)
8) I am leaving the Return button as is
9) Apply patch and repeat steps 1-8. Notice changes to buttons

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 5 Jonathan Druart 2017-02-14 08:35:50 UTC
I am waiting for Owen's confirmation on bug 18042 about the use of btn-primary
Comment 6 Jonathan Druart 2017-02-20 13:45:20 UTC
Switch do in discussion according to bug 18042 comment 5
Comment 7 Katrin Fischer 2023-09-10 11:56:45 UTC
I checked the buttons updated by the patch and they are all marked btn-primary now from the staff interface redesign. Marking RESOLVED.