The buttons in the whole process are styled differently for both modification and deletion. They should use bootstrap 3 styling
Created attachment 59834 [details] [review] Bug 18041: Updating buttons in Batch Item modification and deletion To test: 1) Go to Tools -> Batch item modification 2) Put a barcode in and click Continue (notice ugly button) 3) Scroll to the bottom of the page and click Save (you don't have to make any changes) (Notice ugly button) 4) I am leaving the Return button as is 5) Go to Tools -> Batch item deletion 6) Put a barcode in and click Continue (notice ugly button) 7) Uncheck the selected item (so you don't actually delete anything) and click Delete selected items (Notice ugly button) 8) I am leaving the Return button as is 9) Apply patch and repeat steps 1-8. Notice changes to buttons Sponsored-by: Catalyst IT
The same as comment 2 on bug 18042
Created attachment 59958 [details] [review] Bug 18041: Updating buttons in Batch Item modification and deletion To test: 1) Go to Tools -> Batch item modification 2) Put a barcode in and click Continue (notice ugly button) 3) Scroll to the bottom of the page and click Save (you don't have to make any changes) (Notice ugly button) 4) I am leaving the Return button as is 5) Go to Tools -> Batch item deletion 6) Put a barcode in and click Continue (notice ugly button) 7) Uncheck the selected item (so you don't actually delete anything) and click Delete selected items (Notice ugly button) 8) I am leaving the Return button as is 9) Apply patch and repeat steps 1-8. Notice changes to buttons Sponsored-by: Catalyst IT
Created attachment 60118 [details] [review] Bug 18041: Updating buttons in Batch Item modification and deletion To test: 1) Go to Tools -> Batch item modification 2) Put a barcode in and click Continue (notice ugly button) 3) Scroll to the bottom of the page and click Save (you don't have to make any changes) (Notice ugly button) 4) I am leaving the Return button as is 5) Go to Tools -> Batch item deletion 6) Put a barcode in and click Continue (notice ugly button) 7) Uncheck the selected item (so you don't actually delete anything) and click Delete selected items (Notice ugly button) 8) I am leaving the Return button as is 9) Apply patch and repeat steps 1-8. Notice changes to buttons Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
I am waiting for Owen's confirmation on bug 18042 about the use of btn-primary
Switch do in discussion according to bug 18042 comment 5
I checked the buttons updated by the patch and they are all marked btn-primary now from the staff interface redesign. Marking RESOLVED.