ODS and XML Marc framework exports are still floody. Correct the floodiness. See also bug 17389 and bug 16035. If there is an undef, using blank, q{}, instead.
Created attachment 60434 [details] [review] Bug 18143: Silence XML MARC Framework export flood TEST PLAN --------- 1) Log in to staff client 2) Click Koha administration 3) Click MARC bibliographic framework 4) export default as xml 5) Read the error log -- it's floody and export is default framework 6) export another framework as xml 7) Read the error log -- it's floody and export is the correct framework 8) apply the patch 9) repeat steps 4-7 -- expected frameworks exported, and no flooding. 10) run koha qa test tools
Created attachment 60435 [details] [review] Bug 18143: Silence ods MARC framework export flood
Created attachment 83825 [details] [review] Bug 18143: Silence XML MARC Framework export flood TEST PLAN --------- 1) Log in to staff client 2) Click Koha administration 3) Click MARC bibliographic framework 4) export default as xml 5) Read the error log -- it's floody and export is default framework 6) export another framework as xml 7) Read the error log -- it's floody and export is the correct framework 8) apply the patch 9) repeat steps 4-7 -- expected frameworks exported, and no flooding. 10) run koha qa test tools Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 83826 [details] [review] Bug 18143: Silence ods MARC framework export flood Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 84968 [details] [review] Bug 18143: Silence XML MARC Framework export flood TEST PLAN --------- 1) Log in to staff client 2) Click Koha administration 3) Click MARC bibliographic framework 4) export default as xml 5) Read the error log -- it's floody and export is default framework 6) export another framework as xml 7) Read the error log -- it's floody and export is the correct framework 8) apply the patch 9) repeat steps 4-7 -- expected frameworks exported, and no flooding. 10) run koha qa test tools Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 84969 [details] [review] Bug 18143: Silence ods MARC framework export flood Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04.. it's never good to flood the logs.
backported to 18.05.x for 18.05.11
Pushed to 17.11.x for 17.11.17