Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18584 (introduces layout grid) - Create a card layout wir a text field, an image and barcode. Use points as layout unit - Activate layout grid - Create PDF output, save. - Change layout unit to mm. - Create PDF output, save. - Compare PDFs. Verify that the positions are unchanged.
Please test on top of Bug 18541 - Patron card creator: Add a grid to support layout design Sorry for wrong bug number in intitial comment.
Created attachment 63167 [details] [review] Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout wir a text field, an image and barcode. Use points as layout unit - Activate layout grid - Create PDF output, save. - Change layout unit to mm. - Create PDF output, save. - Compare PDFs. Verify that the positions are unchanged (still using points). - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) Note: Patch not yet ready to sign-off because of som e c/p, but tests are welcome.
Created attachment 63219 [details] [review] Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units
Created attachment 63320 [details] [review] [SIGNED-OFF] Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Still applies on current master
Still applies on current master.
Created attachment 66932 [details] [review] Follow-up: Add POD descriptions to subs This patch simply adds POD descriptions to subs affected by first patch.
Still applies on current master. Would be nice to have it in next release because current behaviour is really a malfunction.
Created attachment 67670 [details] [review] Bug 18550 - Patron card creator: Print output does not respect layout units To reproduce: Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout. To reproduce: - Test on top of Bug 18541 (introduces layout grid) - Create a card layout with a text field, an image and a barcode. Use points as layout unit - Activate layout grid - Create PDF output, save - Change layout unit to mm - Create PDF output, save - Compare PDFs. Verify that the positions are unchanged (still using points) To test: - Apply patch - Create again PDF - Verify that elements are positionad as expected (using unit, e.g. mm) - Bonus test: Repeat with other units Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 67671 [details] [review] Bug 18550: [Follow-up] Add POD descriptions to subs This patch simply adds POD descriptions to subs affected by first patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Testing Patron Card from scratch is not very intuitive. The code changes dont look bad. I loose my barcode when I use this patch set, but I trust that the test results of Mark and Josef are based on better card templates etc.
Pushed to master for 17.11, thanks to everybody involved!
Depends on Bug 18541 that is not in 17.05.x