Bug 18626 - Add ability to track cardnumber changes for patrons
Summary: Add ability to track cardnumber changes for patrons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Josef Moravec
URL:
Keywords:
: 19226 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-05-18 14:35 UTC by Kyle M Hall
Modified: 2019-07-25 12:19 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18626 - Add ability to track cardnumber changes for patrons (2.57 KB, patch)
2017-05-18 14:38 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18626 - Add ability to track cardnumber changes for patrons (2.74 KB, patch)
2017-05-19 05:49 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 18626 - Add ability to track cardnumber changes for patrons (2.79 KB, patch)
2017-12-03 09:26 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 18626 - Add ability to track cardnumber changes for patrons (2.81 KB, patch)
2018-03-09 14:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18626: Add unit tests (1.40 KB, patch)
2018-03-09 14:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 18626: Add unit tests (1.79 KB, patch)
2018-03-09 15:02 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2017-05-18 14:35:34 UTC
Some libraries want to keep a history of cardnumber changes for a patron. This is a feature that another ILS has.
Comment 1 Kyle M Hall 2017-05-18 14:38:51 UTC
Created attachment 63532 [details] [review]
Bug 18626 - Add ability to track cardnumber changes for patrons

Some libraries want to keep a history of cardnumber changes for a
patron. This is a feature that another ILS has.

Test Plan:
1) Apply this patch
2) Enable the BorrowersLog
3) Modify a patron, update his or her cardnumber
4) Notice the entry in the action log containing the old and new cardnumbers
5) Edit a patron, leave the cardnumber the same
6) Note there is no cardnumber change entry in the action logs
7) Disable BorrowersLog, modify a patron cardnumber
8) Note there is no cardnumber change entry in teh action logs
Comment 2 Marc Véron 2017-05-19 05:49:09 UTC
Created attachment 63560 [details] [review]
Bug 18626 - Add ability to track cardnumber changes for patrons

Some libraries want to keep a history of cardnumber changes for a
patron. This is a feature that another ILS has.

Test Plan:
1) Apply this patch
2) Enable the BorrowersLog
3) Modify a patron, update his or her cardnumber
4) Notice the entry in the action log containing the old and new cardnumbers
5) Edit a patron, leave the cardnumber the same
6) Note there is no cardnumber change entry in the action logs
7) Disable BorrowersLog, modify a patron cardnumber
8) Note there is no cardnumber change entry in teh action logs

Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Christopher Brannon 2017-08-31 15:08:49 UTC
*** Bug 19226 has been marked as a duplicate of this bug. ***
Comment 4 Christopher Brannon 2017-08-31 15:09:33 UTC
(In reply to Christopher Brannon from comment #3)
> *** Bug 19226 has been marked as a duplicate of this bug. ***

Thanks for catching this.
Comment 5 Josef Moravec 2017-12-03 09:26:14 UTC
Created attachment 69467 [details] [review]
Bug 18626 - Add ability to track cardnumber changes for patrons

Some libraries want to keep a history of cardnumber changes for a
patron. This is a feature that another ILS has.

Test Plan:
1) Apply this patch
2) Enable the BorrowersLog
3) Modify a patron, update his or her cardnumber
4) Notice the entry in the action log containing the old and new cardnumbers
5) Edit a patron, leave the cardnumber the same
6) Note there is no cardnumber change entry in the action logs
7) Disable BorrowersLog, modify a patron cardnumber
8) Note there is no cardnumber change entry in teh action logs

Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Jonathan Druart 2017-12-11 17:23:32 UTC
Please add tests to cover this change.
Comment 7 Kyle M Hall 2018-03-09 14:52:11 UTC
Created attachment 72607 [details] [review]
Bug 18626 - Add ability to track cardnumber changes for patrons

Some libraries want to keep a history of cardnumber changes for a
patron. This is a feature that another ILS has.

Test Plan:
1) Apply this patch
2) Enable the BorrowersLog
3) Modify a patron, update his or her cardnumber
4) Notice the entry in the action log containing the old and new cardnumbers
5) Edit a patron, leave the cardnumber the same
6) Note there is no cardnumber change entry in the action logs
7) Disable BorrowersLog, modify a patron cardnumber
8) Note there is no cardnumber change entry in teh action logs

Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 8 Kyle M Hall 2018-03-09 14:52:22 UTC
Created attachment 72608 [details] [review]
Bug 18626: Add unit tests
Comment 9 Kyle M Hall 2018-03-09 15:02:41 UTC
Created attachment 72609 [details] [review]
Bug 18626: Add unit tests
Comment 10 Jonathan Druart 2018-03-23 15:35:47 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 11 Nick Clemens 2018-03-26 12:02:32 UTC
Enhancement, not backported for 17.11