Running 'prove t/ImportBatch.t' outputs the following message: t/ImportBatch.t .............................................. 1/3 Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Created attachment 184128 [details] [review] Bug 18772: Remove warnings from t/ImportBatch.t Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Those are 2 warnings coming from MARC::File::XML when called with invalid XML. We should not use Test::Warn as they are not expected and that may be fixed upstream.
Created attachment 184297 [details] [review] Bug 18772: Remove warnings from t/ImportBatch.t Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Those are 2 warnings coming from MARC::File::XML when called with invalid XML. We should not use Test::Warn as they are not expected and that may be fixed upstream. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 184383 [details] [review] Bug 18772: Remove warnings from t/ImportBatch.t Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Those are 2 warnings coming from MARC::File::XML when called with invalid XML. We should not use Test::Warn as they are not expected and that may be fixed upstream. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
That's an interesting path for MARC::File::XML. That looks like a CPAN install? I would've expected /usr/share/perl5/MARC/File/XML.pm for a package install. But I think that I did see this very warning the other day when a colleague was using ./misc/migration_tools/bulkmarcimport.pl. -- Interestingly, it looks like Galen said he fixed this back in July 2017: https://github.com/perl4lib/marc-perl/pull/5 But the version on CPAN is older than that. At a glance, the fix at https://github.com/perl4lib/marc-perl/blob/master/marc-xml/lib/MARC/File/XML.pm#L399 also doesn't look like it would fix the problem...
(In reply to David Cook from comment #6) > At a glance, the fix at > https://github.com/perl4lib/marc-perl/blob/master/marc-xml/lib/MARC/File/XML. > pm#L399 also doesn't look like it would fix the problem... I misunderstood Galen's fix. It does indeed fix the problem. (I just patched the MARC/File/XML file by hand in KTD.)
Asked on https://github.com/perl4lib/marc-perl/issues/10 for Galen to update the CPAN version, and then we can add reports to Debian for updating the versions there.
Pushed to 24.11.x for 24.11.08