Bug 22721 - Normalize GetMarcFromKohaField calls
Summary: Normalize GetMarcFromKohaField calls
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 19096
Blocks: 19097
  Show dependency treegraph
 
Reported: 2019-04-17 05:55 UTC by Josef Moravec
Modified: 2019-04-18 09:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls (54.14 KB, patch)
2019-04-17 06:14 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2019-04-17 05:55:46 UTC

    
Comment 1 Josef Moravec 2019-04-17 06:14:26 UTC
Created attachment 88137 [details] [review]
Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls

Test plan:
Run tests, at least:
    t/db_dependent/Biblio.t
    t/db_dependent/Biblio/TransformHtmlToMarc.t
    t/db_dependent/Charset.t
    t/db_dependent/Circulation/GetTopIssues.t
    t/db_dependent/Filter_MARC_ViewPolicy.t
    t/db_dependent/ImportBatch.t
    t/db_dependent/Items.t
    t/db_dependent/Items/AutomaticItemModificationByAge.t
    t/db_dependent/Items/GetItemsForInventory.t
    t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
    t/db_dependent/Serials.t
    t/db_dependent/XISBN.t
    t/db_dependent/FrameworkPlugin.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 2 Michal Denar 2019-04-17 20:08:41 UTC
Hi Josef,
one test fails :-(

#   at t/db_dependent/Items/GetItemsForInventory.t line 138.
# Looks like you failed 1 test of 9.
t/db_dependent/Items/GetItemsForInventory.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/9 subtests

Test Summary Report
-------------------
t/db_dependent/Items/GetItemsForInventory.t (Wstat: 256 Tests: 9 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=1, Tests=9,  2 wallclock secs ( 0.01 usr  0.01 sys +  1.82 cusr  0.22 csys =  2.06 CPU)
Result: FAIL
Comment 3 Josef Moravec 2019-04-18 09:32:49 UTC
(In reply to Michal Denar from comment #2)
> Hi Josef,
> one test fails :-(
> 
> #   at t/db_dependent/Items/GetItemsForInventory.t line 138.
> # Looks like you failed 1 test of 9.
> t/db_dependent/Items/GetItemsForInventory.t .. Dubious, test returned 1
> (wstat 256, 0x100)
> Failed 1/9 subtests
> 
> Test Summary Report
> -------------------
> t/db_dependent/Items/GetItemsForInventory.t (Wstat: 256 Tests: 9 Failed: 1)
>   Failed test:  7
>   Non-zero exit status: 1
> Files=1, Tests=9,  2 wallclock secs ( 0.01 usr  0.01 sys +  1.82 cusr  0.22
> csys =  2.06 CPU)
> Result: FAIL

Sorry, I can't reproduce it ;(