To reproduce: 1) Create a club template that DOES NOT allow public enrollment 2) Create a club, enrol a user 3) Log in as that user to the OPAC 4) Go to 'your summary' and click the Clubs tab 5) Notice the broken table with empty column 6) Edit the club template to allow public enrollment 7) Notice the table is fixed - so this bug is just when the club does not allow public enrollment
Created attachment 66663 [details] [review] Bug 19216: Fix broken table in OPAC for when club doesn't allow public enrolment To test: 1) Apply bug 19214 and bug 19215 to fix other issues with patron clubs 2) Create a club template that DOES NOT allow public enrollment 3) Create a club, enrol a user 4) Log in as that user to the OPAC 5) Go to 'your summary' and click the Clubs tab 6) Notice the broken table with empty column 7) Edit the club template to allow public enrollment 8) Notice the table is fixed - so this bug is just when the club does not allow public enrollment 9) Apply the patch 10) Edit the club template to NOT ALLOW public enrollment 11) Confirm the table in the OPAC is now fixed and does not leave an empty column Sponsored-by: Catalyst IT
Created attachment 67077 [details] [review] Bug 19216: Fix broken table in OPAC for when club doesn't allow public enrolment To test: 1) Apply bug 19214 and bug 19215 to fix other issues with patron clubs 2) Create a club template that DOES NOT allow public enrollment 3) Create a club, enrol a user 4) Log in as that user to the OPAC 5) Go to 'your summary' and click the Clubs tab 6) Notice the broken table with empty column 7) Edit the club template to allow public enrollment 8) Notice the table is fixed - so this bug is just when the club does not allow public enrollment 9) Apply the patch 10) Edit the club template to NOT ALLOW public enrollment 11) Confirm the table in the OPAC is now fixed and does not leave an empty column Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 68666 [details] [review] Bug 19216: Fix broken table in OPAC for when club doesn't allow public enrolment To test: 1) Apply bug 19214 and bug 19215 to fix other issues with patron clubs 2) Create a club template that DOES NOT allow public enrollment 3) Create a club, enrol a user 4) Log in as that user to the OPAC 5) Go to 'your summary' and click the Clubs tab 6) Notice the broken table with empty column 7) Edit the club template to allow public enrollment 8) Notice the table is fixed - so this bug is just when the club does not allow public enrollment 9) Apply the patch 10) Edit the club template to NOT ALLOW public enrollment 11) Confirm the table in the OPAC is now fixed and does not leave an empty column Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!