Bug 19378 - Onboarding tool should allow configuration of holds
Summary: Onboarding tool should allow configuration of holds
Status: RESOLVED DUPLICATE of bug 22655
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Buckley
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-28 03:36 UTC by David Cook
Modified: 2020-02-26 00:18 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 19378: Configure holds rules in onboarding tool (4.95 KB, patch)
2019-07-25 22:29 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 19378: Configure holds rules in onboarding tool (4.95 KB, patch)
2019-07-25 22:56 UTC, Alex Buckley
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2017-09-28 03:36:41 UTC
At the moment, the onboarding tool allows you to set on-shelf holds but it doesn't let you actually set up allowed hold counts which means holds are disabled by default.
Comment 1 Aleisha Amohia 2019-02-18 02:08:06 UTC
Will start working on this when I get a chance!
Comment 2 Alex Buckley 2019-07-25 22:29:39 UTC
Created attachment 91779 [details] [review]
Bug 19378: Configure holds rules in onboarding tool

At present the onboarding step 5 (Set up issuing rule) does not let you
set a value for issuingrule.reservesallowed, issuingrule.holds_per_day,
issuingrule.holds_per_record this patch adds that functionality so
newly logged in users are able to reserve right after importing biblios.

Test plan:
1. Drop and recreate your database

2. Go through the installer and onboarding tool and notice in the last
page of the onboarding tool (where you set up issuing rules) there is no
input for Reserves allowed, Holds per day or Holds per record

3. Submit the page and jump into the Koha database and run:
SELECT reservesallowed, holds_per_day, holds_per_record from
issuingrules;

Notice all three fields are NULL

4. Apply this patch

5. Drop and create your database and restart memcached and plack

6. Go through the installer and onboarding tool and notice in the last
onboarding tool page there is now three new number input fields: Reserves
allowed, Holds per day and Holds per record

7. Keep the default values for these fields and submit the form

8. Repeat step 4 and notice reservesallowed, holds_per_day and
holds_per_record are now all 10

9. Sign off

Sponsored-By: Catalyst IT
Comment 3 Alex Buckley 2019-07-25 22:56:23 UTC
Created attachment 91781 [details] [review]
Bug 19378: Configure holds rules in onboarding tool

At present the onboarding step 5 (Set up issuing rule) does not let you
set a value for issuingrules.reservesallowed, issuingrules.holds_per_day,
issuingrules.holds_per_record this patch adds that functionality so
newly logged in users are able to reserve right after importing biblios.

Test plan:
1. Drop and recreate your database

2. Go through the installer and onboarding tool and notice in the last
page of the onboarding tool (where you set up issuing rules) there is no
input for Reserves allowed, Holds per day or Holds per record

3. Submit the page and jump into the Koha database and run:
SELECT reservesallowed, holds_per_day, holds_per_record from
issuingrules;

Notice all three fields are NULL

4. Apply this patch

5. Drop and create your database and restart memcached and plack

6. Go through the installer and onboarding tool and notice in the last
onboarding tool page there is now three new number input fields: Reserves
allowed, Holds per day and Holds per record

7. Keep the default values for these fields and submit the form

8. Repeat step 4 and notice reservesallowed, holds_per_day and
holds_per_record are now all 10

9. Sign off

Sponsored-By: Catalyst IT
Comment 4 Jonathan Druart 2019-08-07 01:27:50 UTC
Alex, you are mixing "reserves" and "holds".
Comment 5 Alex Buckley 2019-08-07 02:12:06 UTC
Hi Jonathan, 

Just to clarify do you mean the 'Reserves allowed' text that this patch introduces to the onboardingstep5.tt should be changed to 'Holds allowed', as 'holds' should be used instead of 'reserves' throughout Koha by default as it is in smart-rules.tt?

Thanks for the feedback on this patch!

Thanks,
Alex
Comment 6 Alex Buckley 2020-02-26 00:18:46 UTC
Great work on bug 22655 Aleisha!

*** This bug has been marked as a duplicate of bug 22655 ***