To recreate: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty
Created attachment 68593 [details] [review] Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values
Even after applying the patch, the itemtype dropdown remains empty when a staff override is required.
Created attachment 68723 [details] [review] Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values
Created attachment 68805 [details] [review] Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 69372 [details] [review] Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 18.05, thanks to everybody involved!
Pushed to stable for 17.11.01, awesome work all!
Pushed to 17.05.x, will be in v17.05.07 Looks like the same code is in if and else now, strange o_O