Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override
Summary: Hold pulldown for itemtype is empty if hold placement needs override
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-26 11:35 UTC by Kyle M Hall
Modified: 2017-12-07 12:40 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override (1.27 KB, patch)
2017-10-26 11:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override (1.22 KB, patch)
2017-10-27 14:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override (1.28 KB, patch)
2017-10-28 13:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override (1.37 KB, patch)
2017-11-27 12:25 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2017-10-26 11:35:37 UTC
To recreate:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
   warning.
4) Note the itemtype pulldown is empty
Comment 1 Kyle M Hall 2017-10-26 11:37:18 UTC
Created attachment 68593 [details] [review]
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override

Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
   warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values
Comment 2 Andreas Hedström Mace 2017-10-26 20:40:14 UTC
Even after applying the patch, the itemtype dropdown remains empty when a staff override is required.
Comment 3 Kyle M Hall 2017-10-27 14:21:30 UTC
Created attachment 68723 [details] [review]
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override

Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
   warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values
Comment 4 Katrin Fischer 2017-10-28 13:11:05 UTC
Created attachment 68805 [details] [review]
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override

Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
   warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Marcel de Rooy 2017-11-27 12:25:46 UTC
Created attachment 69372 [details] [review]
Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override

Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
   warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Jonathan Druart 2017-12-07 12:40:00 UTC
Pushed to master for 18.05, thanks to everybody involved!