This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be two patron-related templates: moremember-brief.tt and update-child.tt.
Created attachment 70435 [details] [review] Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct.
Created attachment 70678 [details] [review] Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct.
Created attachment 70679 [details] [review] Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com>
Depends on a bug not signed off.
(In reply to Jonathan Druart from Bug 19641) > Before: > https://screenshots.firefox.com/aiunxdJJDVm8KUyk/pro.kohadev.org > After: > https://screenshots.firefox.com/hNHmyPk4g8VNpj0C/pro.kohadev.org > > Why is it better? > > Same for the brief view: > Before: > https://screenshots.firefox.com/62t0wbESsXjcuKaO/pro.kohadev.org > After: > https://screenshots.firefox.com/oAnGeNsYW9s3qvTv/pro.kohadev.org I was not trying to change the layout per se, it's a consequence of the grid change. I find the changes to be neutral, especially since the view people will see normally is the small popup. The patron brief view triggered from the duplicate patron warning is always going to look strange if no primary contact information appears.
Please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19954: Update popup window templates to use Bootstrap grid: Patrons Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 19954: Update popup window templates to use Bootstrap grid: Patrons The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19954-Update-popup-window-templates-to-use-Boo-iaYLLo.patch
Created attachment 71746 [details] [review] Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com>
Created attachment 71754 [details] [review] Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 71906 [details] [review] Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Moved buttons are ok for me.
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, not backported for 17.11