Bug 20059 - Option to allow checkin of non-issued items without setting SIP-alert
Summary: Option to allow checkin of non-issued items without setting SIP-alert
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-22 11:58 UTC by Stefan Berndtsson
Modified: 2018-11-14 09:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Syspref for not setting alert flag when book is available (not on loan) (2.70 KB, patch)
2018-01-22 11:59 UTC, Stefan Berndtsson
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Berndtsson 2018-01-22 11:58:23 UTC
SIP-alert is set from the return value of the checkin call. This sets the message NotIssued when the book is already available, causing SIP-alert to be set.

SIP-alert is also used in sorting during checkin, which conflicts with more obvious alerts.

Patch provides an option to allow NotIssued to be SIP-checked-in without triggering the alert flag.
Comment 1 Stefan Berndtsson 2018-01-22 11:59:20 UTC
Created attachment 70792 [details] [review]
Syspref for not setting alert flag when book is available (not on loan)
Comment 2 Magnus Enger 2018-06-05 12:58:46 UTC
Could you provide a test-plan and set the status to "Needs signoff", please?
Comment 3 Colin Campbell 2018-11-01 16:57:17 UTC
Have you thought about the interaction with the change introduced by bug 13411.

Also 13411s change is set in the config file this is set as syspref, it would be better to have a consistent approach
Comment 4 Stefan Berndtsson 2018-11-14 09:37:45 UTC
I will do some poking around, but at first glance 13411 seems to do mostly the same thing, which would make this patch irrelevant. The name of the setting wasn't obvious to me, which is the reason I never found that bug.

Consistency is definitely the best approach, and several other options are set in the SIPconfig, which makes that the most logical place. It would also make it possible to have different behaviour on different stations if that's desirable.