The feature added by bug 18403 should not apply to all library groups. We should add the ability to enable/disable it only for specific hierarchies.
Created attachment 71156 [details] [review] Bug 20133: Add new column library_groups.ft_hide_patron_info
Created attachment 71157 [details] [review] Bug 20133: DBIC Schema changes
Created attachment 71158 [details] [review] Bug 20133: UI Changes Add a checkbox to enable/disable the feature for given group of libraries. Important note: Only the top level node can turn the feature, the idea is to avoid confusion, ease testing (by limiting the number of cases) and force libraries to define one tree per feature (Maybe this is wrong, but maybe good to start)
Created attachment 71159 [details] [review] Bug 20133: Enable/disable the "Hide patron information" feature per group of libraries In order to control this feature correctly it needs to be enabled for group of libraries and not for all groups defined in the system. Groups will be used for different usages and so the feature must not be enabled by default for all of them. Test plan: Retest bug 18403 with the feature turned on/off for a given tree
Created attachment 71296 [details] [review] Bug 20133 [QA Followup] - Tweak new 'group features' section
Created attachment 71368 [details] [review] Bug 20133: Add new column library_groups.ft_hide_patron_info Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71369 [details] [review] Bug 20133: Add new column library_groups.ft_hide_patron_info Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71370 [details] [review] Bug 20133: DBIC Schema changes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71371 [details] [review] Bug 20133: UI Changes Add a checkbox to enable/disable the feature for given group of libraries. Important note: Only the top level node can turn the feature, the idea is to avoid confusion, ease testing (by limiting the number of cases) and force libraries to define one tree per feature (Maybe this is wrong, but maybe good to start) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71372 [details] [review] Bug 20133: Enable/disable the "Hide patron information" feature per group of libraries In order to control this feature correctly it needs to be enabled for group of libraries and not for all groups defined in the system. Groups will be used for different usages and so the feature must not be enabled by default for all of them. Test plan: Retest bug 18403 with the feature turned on/off for a given tree Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 71373 [details] [review] Bug 20133 [QA Followup] - Tweak new 'group features' section Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I am going to push this change along with bug 18403.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Enhancement, not backported to stable.