Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature.
Created attachment 71320 [details] [review] Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to
Created attachment 71321 [details] [review] Bug 20157 - Update Schema
Created attachment 71323 [details] [review] Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to
Created attachment 71324 [details] [review] Bug 20157 - Update Schema
Created attachment 71382 [details] [review] Bug 20157: Save the features that have been checked Previous patch forgot to modify the controller script to save the changes.
Created attachment 71383 [details] [review] Bug 20157: Correctly hide the features for non first level groups
Created attachment 71385 [details] [review] Bug 20157 [QA Followup] - Fix error triggered by subgroups being added to group
Created attachment 71387 [details] [review] Bug 20157: Group search groups together We do not actually need 2 groups, the previous feature worked for both OPAC and STAFF interface. The only difference was the "show_in_pulldown" feature. Here we are going to REMOVE this feature for ergonomic reasons. We will already have 3 features and it will surcharge the interface to add another one. Moreover the feature will have to be applied at the OPAC (and so will add lot of JS checks to keep data consistent: only useful if ft_search_groups_opac is set). Moreover it is quite easy to remove entry from the dropdown list in JavaScript. If people was really using this feature, we will re-add it, just let us know.
Comment on attachment 71385 [details] [review] Bug 20157 [QA Followup] - Fix error triggered by subgroups being added to group Moved to bug 18403
Created attachment 71395 [details] [review] Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 71396 [details] [review] Bug 20157 - Update Schema Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 71397 [details] [review] Bug 20157: Save the features that have been checked Previous patch forgot to modify the controller script to save the changes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 71398 [details] [review] Bug 20157: Correctly hide the features for non first level groups Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 71399 [details] [review] Bug 20157: Do not display OPAC groups on the staff interface Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 71400 [details] [review] Bug 20157: Group search groups together We do not actually need 2 groups, the previous feature worked for both OPAC and STAFF interface. The only difference was the "show_in_pulldown" feature. Here we are going to REMOVE this feature for ergonomic reasons. We will already have 3 features and it will surcharge the interface to add another one. Moreover the feature will have to be applied at the OPAC (and so will add lot of JS checks to keep data consistent: only useful if ft_search_groups_opac is set). Moreover it is quite easy to remove entry from the dropdown list in JavaScript. If people was really using this feature, we will re-add it, just let us know. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I am going to push this change along with bug 16735 and bug 20133.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Enhancement, not backported to stable.