I was working on BZ11373 when I fell on this behavior. It seems like commit 0ab22e1c (BZ18789) introduced a small regression: the [% ELSE %] tag at line 125 of pay.tt disappeared when work was done to replace the 'borrower' object with 'patron'. I'll provide a patch in a jiffy.
Created attachment 71972 [details] [review] Bug 20249: "Patron has no outstanding fines" now appears alongside fines Test plan: 1) Choose two patrons from your database, one who has fines, and the other who does not 2) Visit their 'Fines' page, and click on the 'Pay fines' tab 2.1) If they don't have any fines, you'll only see a blank row 2.2) If they do have fines, the payment form will appear, but the text "... no outstanding fines" will also appear 3) Apply patch 4) Visit once again the 'Pay fines' tab of your patrons 4.1) Now, "... no outstanding fines" will appear for the right situation
Created attachment 71973 [details] [review] Bug 20249: (bug 18789 follow-up) "Patron has no outstanding fines" now appears alongside fines Test plan: 1) Choose two patrons from your database, one who has fines, and the other who does not 2) Visit their 'Fines' page, and click on the 'Pay fines' tab 2.1) If they don't have any fines, you'll only see a blank row 2.2) If they do have fines, the payment form will appear, but the text "... no outstanding fines" will also appear 3) Apply patch 4) Visit once again the 'Pay fines' tab of your patrons 4.1) Now, "... no outstanding fines" will appear for the right situation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patch pushed to master for 18.05 Thanks for catching that Charles!
*** Bug 20233 has been marked as a duplicate of this bug. ***
Depends on 18789 which is not in stable