The input text fields in the following pages of the Koha staff client are wider than the fieldset class elements they are contained within: acqui/invoices.tt members/member.tt circ/overdue.tt acqui/parcel.tt
Created attachment 72394 [details] [review] Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT
Created attachment 72395 [details] [review] Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT
I could not see any difference after applying the patch and I am not sure to understand very well the goal of this patch (because of my english level?). Any picture appreciated.
(In reply to jmbroust from comment #3) > I could not see any difference after applying the patch and I am not sure to > understand very well the goal of this patch (because of my english level?). > Any picture appreciated. What is also not mentioned is restart_all on a kohadevbox. Caching is such a pain.
Created attachment 73299 [details] [review] Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT
Created attachment 73467 [details] [review] k
Mark, your sign-off line is missing. I've added it in.
Created attachment 73468 [details] [review] Bug 20329: Shorten the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Will need a follow-pu, if pushed after bug 19474.
It is not a good idea to specify a size in px, you should use a relative lenght instead. We already have div.yui-b fieldset.brief select { width: 12em; } 12em sounds like a good value here. Maybe the following addition would be enough: div.yui-b fieldset.brief input { width: 12em; }
Created attachment 74842 [details] [review] Bug 20329: Text input fields are wider than the fieldset class they are inside of This alternate patch defines a width of 100% for text inputs and selects inside sidebar fieldsets. The scope of this style is limited to the sidebar by unsetting the width for fieldsets within "#yui-main," the main body of the page. This patch also removes inline styles from two templates which are now unnecessary. To test, apply the patch and clear your cache if necessary. View various pages which have a sidebar search form: acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that form fields in the sidebar look correct. Confirm that other forms styled with the "brief" class aren't unintentionally affected by this patch. For example: circ/request-article.pl, members/member-password.pl, reports/reports-home.pl, reserve/request.pl
Created attachment 74845 [details] [review] Bug 20329: Text input fields are wider than the fieldset class they are inside of This alternate patch defines a width of 100% for text inputs and selects inside sidebar fieldsets. The scope of this style is limited to the sidebar by unsetting the width for fieldsets within "#yui-main," the main body of the page. This patch also removes inline styles from two templates which are now unnecessary. To test, apply the patch and clear your cache if necessary. View various pages which have a sidebar search form: acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that form fields in the sidebar look correct. Confirm that other forms styled with the "brief" class aren't unintentionally affected by this patch. For example: circ/request-article.pl, members/member-password.pl, reports/reports-home.pl, reserve/request.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 74901 [details] [review] Bug 20329: Shorten the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74902 [details] [review] Bug 20329: Text input fields are wider than the fieldset class they are inside of This alternate patch defines a width of 100% for text inputs and selects inside sidebar fieldsets. The scope of this style is limited to the sidebar by unsetting the width for fieldsets within "#yui-main," the main body of the page. This patch also removes inline styles from two templates which are now unnecessary. To test, apply the patch and clear your cache if necessary. View various pages which have a sidebar search form: acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that form fields in the sidebar look correct. Confirm that other forms styled with the "brief" class aren't unintentionally affected by this patch. For example: circ/request-article.pl, members/member-password.pl, reports/reports-home.pl, reserve/request.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 18.05, thanks to everybody involved!