Have this patch set in test stage on 16.11. Plan to move them upwards after the 18.05 release.
Created attachment 107506 [details] [review] Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 107507 [details] [review] Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 107508 [details] [review] Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 107509 [details] [review] Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 107510 [details] [review] Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 107511 [details] [review] DO_NOT_PUSH: Change DBIx schema file ArticleRequest
Created attachment 107512 [details] [review] Bug 20472: Update translated AR notices de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line.
(In reply to Marcel de Rooy from comment #1) > Have this patch set in test stage on 16.11. Plan to move them upwards after > the 18.05 release. The plan changed ;) This patch set has run in production on 16.11 and 18.05. And I rebased for 19.11 and master now.
Adding bug 26088 as a see also (for now) on this report in order to address financial follow-up for such a service.
Can you explain more about how the URL field is supposed to be used? Where do the URLs come from?
(In reply to Owen Leonard from comment #11) > Can you explain more about how the URL field is supposed to be used? Where > do the URLs come from? Good question. I leave some room for customization here too. (We use the AR slip and OCR to tag scanned files with the article request number. And then use opac/svc/requests (see bug 20570 follow-up) to add a Dropbox link to the request.) But bug 20570 also contains complete_article_requests.pl to match uploaded files in Koha with article requests. Apart from bug 20570, this development here allows you to manually add links (without saying how they were created indeed).
Created attachment 111473 [details] [review] Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 111474 [details] [review] Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 111475 [details] [review] Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 111476 [details] [review] Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 111477 [details] [review] Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 111478 [details] [review] DO_NOT_PUSH: Change DBIx schema file ArticleRequest
Created attachment 111479 [details] [review] Bug 20472: Update translated AR notices de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line.
Rebased. Please test ! Last submit waited three months.
This development is actually very important for us and received no interest from anyone since 2018. Obviously it did and does not apply anymore at some point in time.
CONFLICT (modify/delete): installer/data/mysql/uk-UA/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/uk-UA/mandatory/sample_notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/ru-RU/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/ru-RU/mandatory/sample_notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/pl-PL/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/pl-PL/mandatory/sample_notices.sql left in tree. I will leave these out now.
CONFLICT (modify/delete): installer/data/mysql/it-IT/necessari/notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/it-IT/necessari/notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/de-DE/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/de-DE/mandatory/sample_notices.sql left in tree. Could be added back later on.
(In reply to Marcel de Rooy from comment #9) > The plan changed ;) This patch set has run in production on 16.11 and 18.05. > And I rebased for 19.11 and master now. So I had this stuff on 16.11, 18.05, 19.11, 20.06 and 21.06 now :)
Note for QA: Should we try to update existing notices here too ?
Created attachment 122366 [details] [review] Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 122367 [details] [review] Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 122368 [details] [review] Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 122369 [details] [review] Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 122370 [details] [review] Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 122371 [details] [review] Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line.
Created attachment 122372 [details] [review] Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21
Created attachment 122373 [details] [review] Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 122374 [details] [review] Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 122375 [details] [review] Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 122376 [details] [review] Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 122377 [details] [review] Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 122378 [details] [review] Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 122379 [details] [review] Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This works really nicely and the code is nice and clean.. Signing off. However.. QA script highlights some missing filters.. a quick follow-up should resolve those ;)
Created attachment 122382 [details] [review] Bug 20472: (QA follow-up) Add few TT filters Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> No more warns from qa tools.
Created attachment 122383 [details] [review] Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(In reply to Marcel de Rooy from comment #25) > Note for QA: > > Should we try to update existing notices here too ? No we have logs for notices changes, we could theoretically try.. but I don't see that as a blocker for this either.
Created attachment 122699 [details] [review] Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122700 [details] [review] Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122701 [details] [review] Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122702 [details] [review] Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122703 [details] [review] Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122704 [details] [review] Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122705 [details] [review] Bug 20472: (QA follow-up) Add few TT filters Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> No more warns from qa tools. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122706 [details] [review] Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(In reply to Nick Clemens from comment #44) > Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Great! Thx
Created attachment 122775 [details] [review] Bug 20472: Make DB rev idempotent
Created attachment 122781 [details] [review] Bug 20472: Add kohastructure changes
Pushed to master for 21.11, thanks to everybody involved!
(In reply to Jonathan Druart from comment #54) > Created attachment 122781 [details] [review] [review] > Bug 20472: Add kohastructure changes Thanks. Is that really true :) Somewhere it has got lost in the rebase. The first obsolete patch included it, aarg.
Enhancement not backported for 21.05