Bug 20671 - Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt
Summary: Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt
Status: RESOLVED DUPLICATE of bug 19012
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-27 15:47 UTC by Jesse Maseto
Modified: 2019-06-07 12:48 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
This patch adds 'surname to the instructions for importing patrons. (2.13 KB, patch)
2018-04-27 16:12 UTC, Jesse Maseto
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Maseto 2018-04-27 15:47:26 UTC
It appears that surname is now a required field when importing a file with patron data.

According to the instructions, however, only 'branchcode' and 'categorycode' are required.

Latter should be amended if surname is now required as well.
Comment 1 Jesse Maseto 2018-04-27 16:12:56 UTC
Created attachment 74914 [details] [review]
This patch adds 'surname to the instructions for importing patrons.
Comment 2 Jesse Maseto 2018-04-27 16:17:20 UTC
This patch adds 'surname' to the instructions for importing patrons tool. 

To test:

Go to import_borrowers.pl
View Notes: section on the right side of the page.
Only shows 'branchcode' and 'categorycode' as required fields.
Also view the Help page in the upper right hand corner.
Only shows 'branchcode' and 'categorycode' as required fields.

apply patch

Follow same steps.
Now you will see 'surname' is added.
Comment 3 Katrin Fischer 2018-04-27 18:05:27 UTC
Have you checked which fields are mandatory in your configuration?
Comment 4 Mark Tompsett 2018-05-01 02:04:23 UTC
(In reply to Katrin Fischer from comment #3)
> Have you checked which fields are mandatory in your configuration?

Default kohadevbox has surname|cardnumber in BorrowerMandatoryField.
Categories and branches are part of table constraints.
I believe some derived logic and a rephrase with a list might be better.
Switching to 'In Discussion', because perhaps other indexed fields might also be considered.
Comment 5 Nick Clemens 2019-06-07 12:48:20 UTC

*** This bug has been marked as a duplicate of bug 19012 ***